Skip to content

Commit c5156b8

Browse files
authored
chore: modifying getters and setters in MPU (#3431)
2 parents 4612e72 + e3f9638 commit c5156b8

4 files changed

Lines changed: 18 additions & 18 deletions

File tree

google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,8 @@ UploadPartResponse sendUploadPartRequest(
225225
if (request.userProject() != null) {
226226
httpRequest.getHeaders().put("x-goog-user-project", request.userProject());
227227
}
228-
if (request.getCrc32c() != null) {
229-
addChecksumHeader(request.getCrc32c(), httpRequest.getHeaders());
228+
if (request.crc32c() != null) {
229+
addChecksumHeader(request.crc32c(), httpRequest.getHeaders());
230230
} else {
231231
addChecksumHeader(rewindableContent.getCrc32c(), httpRequest.getHeaders());
232232
}

google-cloud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/MultipartUpload.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ private MultipartUpload(
6060
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
6161
*/
6262
@BetaApi
63-
public String getKey() {
63+
public String key() {
6464
return key;
6565
}
6666

@@ -71,7 +71,7 @@ public String getKey() {
7171
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
7272
*/
7373
@BetaApi
74-
public String getUploadId() {
74+
public String uploadId() {
7575
return uploadId;
7676
}
7777

@@ -82,7 +82,7 @@ public String getUploadId() {
8282
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
8383
*/
8484
@BetaApi
85-
public StorageClass getStorageClass() {
85+
public StorageClass storageClass() {
8686
return storageClass;
8787
}
8888

@@ -93,7 +93,7 @@ public StorageClass getStorageClass() {
9393
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
9494
*/
9595
@BetaApi
96-
public OffsetDateTime getInitiated() {
96+
public OffsetDateTime initiated() {
9797
return initiated;
9898
}
9999

@@ -160,7 +160,7 @@ private Builder() {}
160160
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
161161
*/
162162
@BetaApi
163-
public Builder setKey(String key) {
163+
public Builder key(String key) {
164164
this.key = key;
165165
return this;
166166
}
@@ -173,7 +173,7 @@ public Builder setKey(String key) {
173173
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
174174
*/
175175
@BetaApi
176-
public Builder setUploadId(String uploadId) {
176+
public Builder uploadId(String uploadId) {
177177
this.uploadId = uploadId;
178178
return this;
179179
}
@@ -186,7 +186,7 @@ public Builder setUploadId(String uploadId) {
186186
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
187187
*/
188188
@BetaApi
189-
public Builder setStorageClass(StorageClass storageClass) {
189+
public Builder storageClass(StorageClass storageClass) {
190190
this.storageClass = storageClass;
191191
return this;
192192
}
@@ -199,7 +199,7 @@ public Builder setStorageClass(StorageClass storageClass) {
199199
* @since 2.61.0 This new api is in preview and is subject to breaking changes.
200200
*/
201201
@BetaApi
202-
public Builder setInitiated(OffsetDateTime initiated) {
202+
public Builder initiated(OffsetDateTime initiated) {
203203
this.initiated = initiated;
204204
return this;
205205
}

google-cloud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/UploadPartRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public String uploadId() {
9898
*/
9999
@BetaApi
100100
@Nullable
101-
public String getCrc32c() {
101+
public String crc32c() {
102102
return crc32c;
103103
}
104104

google-cloud-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,10 +1243,10 @@ public void sendListMultipartUploadsRequest_success() throws Exception {
12431243
.uploads(
12441244
ImmutableList.of(
12451245
MultipartUpload.newBuilder()
1246-
.setKey("test-key")
1247-
.setUploadId("test-upload-id")
1248-
.setStorageClass(StorageClass.STANDARD)
1249-
.setInitiated(
1246+
.key("test-key")
1247+
.uploadId("test-upload-id")
1248+
.storageClass(StorageClass.STANDARD)
1249+
.initiated(
12501250
OffsetDateTime.of(2025, 11, 11, 0, 0, 0, 0, ZoneOffset.UTC))
12511251
.build()))
12521252
.build();
@@ -1285,9 +1285,9 @@ public void sendListMultipartUploadsRequest_success() throws Exception {
12851285
assertThat(response.uploads()).hasSize(1);
12861286

12871287
MultipartUpload upload = response.uploads().get(0);
1288-
assertThat(upload.getKey()).isEqualTo("test-key");
1289-
assertThat(upload.getStorageClass()).isEqualTo(StorageClass.STANDARD);
1290-
assertThat(upload.getInitiated())
1288+
assertThat(upload.key()).isEqualTo("test-key");
1289+
assertThat(upload.storageClass()).isEqualTo(StorageClass.STANDARD);
1290+
assertThat(upload.initiated())
12911291
.isEqualTo(OffsetDateTime.of(2025, 11, 11, 0, 0, 0, 0, ZoneOffset.UTC));
12921292
}
12931293
}

0 commit comments

Comments
 (0)