chore(tests): fix many mainline test issues#190
Merged
Conversation
1) test_spanner_vector_store's dependency on HNLoader fails - use a different loader 2) test_spanner_vector_store's add_document failed with PK size exceeded (this is due to 1, the loader now returns slightly longer content) - use a different url 3) test_spanner_loader doesn't properly clean up the test so that now testing database has too many tables - add cleanup for these tests
product-auto-label
Bot
added
the
api: spanner
Contributor
Author
|
/gbrun |
Contributor
Author
|
/gcbrun |
The old databases are extremely slow due to too many schema objects Also verified pytest test/integrations/ properly cleaned up upon test completion
Contributor
Author
|
@jordimas, feel free to retry your PR submission after this fix. |
averikitsch
approved these changes
Jul 21, 2025
averikitsch
changed the title
kurtisvg
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_spanner_vector_store's dependency on HNLoader fails
test_spanner_vector_store's add_document failed with PK size exceeded
(this is due to 1, the loader now returns slightly longer content)
test_spanner_loader doesn't properly clean up the test so that now
testing database has too many tables
change the default test databases: