Skip to content

Commit b2df615

Browse files
authored
feat(tool/cmd/migrate): set php default for common_resources (#6836)
Add a global default to `common_resources` to true. Will do followup to parse per API value from BUILD.bazel. This global default un-blocks testing with generate. For #6813
1 parent 482238f commit b2df615

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

tool/cmd/migrate/librarian_php.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@
2222
# This file is embedded in tool/cmd/migrate/php.go.
2323
# If you need to update the default tool versions for future migrations, update them here.
2424
language: php
25+
default:
26+
php:
27+
common_resources: true
2528
tools:
2629
composer:
2730
- name: google/gapic-generator-php

tool/cmd/migrate/php_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ func TestRunPHPMigration(t *testing.T) {
7272
if err != nil {
7373
t.Fatal(err)
7474
}
75+
commonResources := true
7576
want := &config.Config{
7677
Language: config.LanguagePhp,
7778
Sources: &config.Sources{
@@ -80,6 +81,11 @@ func TestRunPHPMigration(t *testing.T) {
8081
SHA256: "sha123",
8182
},
8283
},
84+
Default: &config.Default{
85+
PHP: &config.PHPDefault{
86+
CommonResources: &commonResources,
87+
},
88+
},
8389
Libraries: []*config.Library{
8490
{
8591
Name: "SecretManager",

0 commit comments

Comments
 (0)