refactor(internal/serviceconfig): rename NoRESTNumericEnums to SkipRESTNumericEnums (#5084)

NoRESTNumericEnums used a `map[string]bool` to track languages that
should not pass the rest-numeric-enums flag. The double negation in the
name was confusing, and the bool value introduces ambiguity since the
zero value (false) is indistinguishable from an explicit setting.

Replace this with a `[]string` of languages that skip the
rest-numeric-enums flag. This removes the double negation and avoids the
zero-value ambiguity.

Fixes #4086

Author: julieqiu

doc/api-allowlist-schema.md

@@ -12,7 +12,7 @@ This document describes the schema for the API Allowlist.
 | `documentation_uri` | string | Overrides the product documentation URI from the service config's publishing section. |
 | `languages` | list of string | Restricts which languages can generate client libraries for this API. Use "all" to indicate all languages can use this API.<br><br>Restrictions exist for several reasons:<br>- Newer languages (Rust, Dart) skip older beta versions when stable versions exist<br>- Python has historical legacy APIs not available to other languages<br>- Some APIs (like DIREGAPIC protos) are only used by specific languages |
 | `new_issue_uri` | string | Overrides the new issue URI from the service config's publishing section. |
-| `no_rest_numeric_enums` | map[string]bool | Determines whether to use numeric enums in REST requests. The "No" prefix is used because the default behavior (when this field is `false` or omitted) is to generate numeric enums. Map key is the language name (e.g., "python", "rust"). Optional. If omitted, the generator default is used. |
+| `skip_rest_numeric_enums` | list of string | Lists languages that should not pass the rest-numeric-enums flag to the generator. The special value "all" skips it for every language. If empty, all languages use numeric enums. |
 | `open_api` | string | Is the file path to an OpenAPI spec, currently in internal/testdata. This is not an official spec yet and exists only for Rust to validate OpenAPI support. |
 | `release_level` | map[string]string | Is the release level per language. Map key is the language name (e.g., "python", "rust"). Optional. If omitted, the generator default is used.<br><br>TODO(https://github.com/googleapis/librarian/issues/4834): Go uses "alpha", "beta", and "ga" instead of "preview" and "stable". We should standardize release level vocabulary across languages. |
 | `short_name` | string | Overrides the API short name from the service config's publishing section. |

internal/librarian/java/generate_test.go

@@ -89,9 +89,7 @@ func TestResolveGAPICOptions(t *testing.T) {
 				Transports: map[string]serviceconfig.Transport{
 					config.LanguageJava: serviceconfig.GRPCRest,
 				},
-				NoRESTNumericEnums: map[string]bool{
-					config.LanguageJava: true,
-				},
+				SkipRESTNumericEnums: []string{config.LanguageJava},
 			},
 			want: []string{
 				"metadata",

internal/serviceconfig/api.go

@@ -76,12 +76,10 @@ type API struct {
 	// publishing section.
 	NewIssueURI string `yaml:"new_issue_uri,omitempty"`
 
-	// NoRESTNumericEnums determines whether to use numeric enums in REST requests.
-	// The "No" prefix is used because the default behavior (when this field is `false` or omitted) is
-	// to generate numeric enums.
-	// Map key is the language name (e.g., "python", "rust").
-	// Optional. If omitted, the generator default is used.
-	NoRESTNumericEnums map[string]bool `yaml:"no_rest_numeric_enums,omitempty"`
+	// SkipRESTNumericEnums lists languages that should not pass the
+	// rest-numeric-enums flag to the generator. The special value "all"
+	// skips it for every language. If empty, all languages use numeric enums.
+	SkipRESTNumericEnums []string `yaml:"skip_rest_numeric_enums,omitempty"`
 
 	// OpenAPI is the file path to an OpenAPI spec, currently in internal/testdata.
 	// This is not an official spec yet and exists only for Rust to validate OpenAPI support.
@@ -132,18 +130,15 @@ func (api *API) Transport(language string) Transport {
 
 // HasRESTNumericEnums reports whether the generator should pass the
 // rest-numeric-enums option for the given language. The default (when
-// NoRESTNumericEnums is empty) is true.
+// SkipRESTNumericEnums is empty) is true.
 func (api *API) HasRESTNumericEnums(language string) bool {
-	if len(api.NoRESTNumericEnums) == 0 {
+	if len(api.SkipRESTNumericEnums) == 0 {
 		return true
 	}
-	if _, ok := api.NoRESTNumericEnums[config.LanguageAll]; ok {
-		return false
-	}
-	if _, ok := api.NoRESTNumericEnums[language]; ok {
+	if slices.Contains(api.SkipRESTNumericEnums, config.LanguageAll) {
 		return false
 	}
-	return true
+	return !slices.Contains(api.SkipRESTNumericEnums, language)
 }
 
 // ReleaseLevel gets the release level for a given language.

internal/serviceconfig/api_test.go

@@ -217,26 +217,26 @@ func TestHasRESTNumericEnums(t *testing.T) {
 			want: true,
 		},
 		{
-			name: "nil map enables numeric enums",
-			sc:   &API{NoRESTNumericEnums: nil},
+			name: "nil list enables numeric enums",
+			sc:   &API{SkipRESTNumericEnums: nil},
 			lang: config.LanguageNodejs,
 			want: true,
 		},
 		{
-			name: "disabled for all languages",
-			sc:   &API{NoRESTNumericEnums: map[string]bool{config.LanguageAll: true}},
+			name: "skipped for all languages",
+			sc:   &API{SkipRESTNumericEnums: []string{config.LanguageAll}},
 			lang: config.LanguageGo,
 			want: false,
 		},
 		{
-			name: "disabled for specific language",
-			sc:   &API{NoRESTNumericEnums: map[string]bool{config.LanguageNodejs: true}},
+			name: "skipped for specific language",
+			sc:   &API{SkipRESTNumericEnums: []string{config.LanguageNodejs}},
 			lang: config.LanguageNodejs,
 			want: false,
 		},
 		{
-			name: "disabled for other language only",
-			sc:   &API{NoRESTNumericEnums: map[string]bool{"python": true}},
+			name: "skipped for other language only",
+			sc:   &API{SkipRESTNumericEnums: []string{"python"}},
 			lang: config.LanguageGo,
 			want: true,
 		},