fix(toolbox-langchain): avoid duplicated parameter descriptions#680
Open
WilliamK112 wants to merge 1 commit into
Open
fix(toolbox-langchain): avoid duplicated parameter descriptions#680WilliamK112 wants to merge 1 commit into
WilliamK112 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Yuan325
added
the
priority: p1
anubhav756
force-pushed
the
wk/fix-langchain-duplicate-param-descriptions
branch
from
0ed0c21 to
86be7ae
Compare
Contributor
|
/gcbrun |
anubhav756
approved these changes
Jul 9, 2026
dishaprakash
reviewed
Jul 9, 2026
|
|
||
|
|
||
| def _get_tool_description(core_tool: ToolboxCoreTool) -> str: | ||
| description = core_tool._description |
Contributor
There was a problem hiding this comment.
in the case the tool lacks the description, would this raise an attribute error or fallback to doc ?
| sync_mock.__name__ = "test_tool_name_for_langchain" | ||
| sync_mock.__doc__ = tool_schema_dict["description"] | ||
| sync_mock._description = tool_schema_dict["description"] | ||
| sync_mock.__doc__ = ( |
Contributor
There was a problem hiding this comment.
Can we add a test to check the fallback to doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/mcp-toolbox#1327.
LangChain tools currently use the core tool
__doc__as theBaseTooldescription. The core docstring intentionally appends anArgs:section for Python introspection, but LangChain already receives parameter descriptions throughargs_schema, so the LLM-facing tool description duplicates every parameter description.This changes the LangChain wrappers to use the core tool's raw
_descriptionwhen available, while preserving a fallback to__doc__for compatibility with older or mocked tool objects. Regression coverage checks that the LangChain tool description no longer includesArgs:while parameter descriptions remain available throughargs_schema.Validation:
pytest tests/test_client.py tests/test_async_client.py tests/test_tools.py tests/test_async_tools.pyblack --check src testsisort --check src testsMYPYPATH='./src:../toolbox-core/src' mypy --install-types --non-interactive --cache-dir=.mypy_cache/ -p toolbox_langchainNote: the full
pytest testssuite includes E2E coverage that expects a Toolbox service/version environment, so I used the non-E2E LangChain package test set above for this wrapper change.