Skip to content

Commit 2fa82e5

Browse files
committed
fix(tools/looker): log request/response traces at debug, not error
The looker-get-dashboards and looker-generate-embed-url tools logged their "Making request"/"Got response" traces with logger.ErrorContext, while every other Looker tool logs the same traces with logger.DebugContext. Because StdLogger routes Error to stderr, these routine, successful traces surfaced as ERROR-severity stderr lines on every call at the default log level: log spam and false positives for log-based alerting. Switch the four calls to DebugContext so they match the package convention and are suppressed at the default log level. Message strings are unchanged.
1 parent 35c13ad commit 2fa82e5

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

internal/tools/looker/lookergenerateembedurl/lookergenerateembedurl.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,15 +135,15 @@ func (t Tool) Invoke(ctx context.Context, resourceMgr tools.SourceProvider, para
135135
SessionLength: &sessionLength,
136136
ForceLogoutLogin: &forceLogoutLogin,
137137
}
138-
logger.ErrorContext(ctx, "Making request %v", req)
138+
logger.DebugContext(ctx, "Making request %v", req)
139139
resp, err := sdk.CreateEmbedUrlAsMe(req, nil)
140140
if err != nil {
141141
if strings.Contains(err.Error(), "status=401") {
142142
return nil, util.NewClientServerError("unauthorized error", http.StatusUnauthorized, err)
143143
}
144144
return nil, util.ProcessGeneralError(err)
145145
}
146-
logger.ErrorContext(ctx, "Got response %v", resp)
146+
logger.DebugContext(ctx, "Got response %v", resp)
147147

148148
return resp, nil
149149
}

internal/tools/looker/lookergetdashboards/lookergetdashboards.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,15 @@ func (t Tool) Invoke(ctx context.Context, resourceMgr tools.SourceProvider, para
137137
Limit: &limit,
138138
Offset: &offset,
139139
}
140-
logger.ErrorContext(ctx, "Making request %v", req)
140+
logger.DebugContext(ctx, "Making request %v", req)
141141
resp, err := sdk.SearchDashboards(req, source.LookerApiSettings())
142142
if err != nil {
143143
if strings.Contains(err.Error(), "status=401") {
144144
return nil, util.NewClientServerError("unauthorized error", http.StatusUnauthorized, err)
145145
}
146146
return nil, util.ProcessGeneralError(err)
147147
}
148-
logger.ErrorContext(ctx, "Got response %v", resp)
148+
logger.DebugContext(ctx, "Got response %v", resp)
149149
var data []any
150150
for _, v := range resp {
151151
logger.DebugContext(ctx, "Got response element of %v\n", v)

0 commit comments

Comments
 (0)