Commit 2fa82e5
committed
fix(tools/looker): log request/response traces at debug, not error
The looker-get-dashboards and looker-generate-embed-url tools logged their
"Making request"/"Got response" traces with logger.ErrorContext, while every
other Looker tool logs the same traces with logger.DebugContext. Because
StdLogger routes Error to stderr, these routine, successful traces surfaced as
ERROR-severity stderr lines on every call at the default log level: log spam
and false positives for log-based alerting.
Switch the four calls to DebugContext so they match the package convention and
are suppressed at the default log level. Message strings are unchanged.1 parent 35c13ad commit 2fa82e5
2 files changed
Lines changed: 4 additions & 4 deletions
File tree
- internal/tools/looker
- lookergenerateembedurl
- lookergetdashboards
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
138 | | - | |
| 138 | + | |
139 | 139 | | |
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | | - | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
148 | | - | |
| 148 | + | |
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| |||
0 commit comments