Skip to content

feat(scylladb): adding support for ScyllaDB source and tool#3119

Open
zseta wants to merge 10 commits into
googleapis:mainfrom
zseta:feat-scylladb
Open

feat(scylladb): adding support for ScyllaDB source and tool#3119
zseta wants to merge 10 commits into
googleapis:mainfrom
zseta:feat-scylladb

Conversation

@zseta
Copy link
Copy Markdown

@zseta zseta commented Apr 23, 2026

Description

Adds support for ScyllaDB source and tool using the ScyllaDB Go driver.

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #3117

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for ScyllaDB as a data source and provides a ScyllaDB CQL tool. It includes the necessary CI configuration, source and tool implementations, unit tests, and integration tests. Feedback focuses on improving JSON serialization consistency by initializing slices, adopting modern Go "any" syntax, enhancing error messages for query failures, and simplifying internal interfaces by removing unused methods.

Comment thread internal/sources/scylladb/scylladb.go
Comment thread internal/sources/scylladb/scylladb.go Outdated
Comment thread internal/tools/scylladb/scyllacql/scyllacql.go
Comment thread tests/scylladb/scylladb_integration_test.go Outdated
zseta and others added 4 commits April 23, 2026 18:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@zseta zseta marked this pull request as ready for review April 27, 2026 15:32
@zseta zseta requested a review from a team as a code owner April 27, 2026 15:32
@zseta
Copy link
Copy Markdown
Author

zseta commented Apr 30, 2026

hi @Yuan325 , can i get some guidance regarding this PR?

@Yuan325 Yuan325 changed the title feat: Add ScyllaDB source and tool feat(scylladb): adding support for ScyllaDB source and tool May 5, 2026
Copy link
Copy Markdown
Contributor

@Yuan325 Yuan325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zseta Thank you for your contribution! Please let me know if you needs any clarifications on the feedback :)

Comment thread tests/scylladb/scylladb_integration_test.go
Comment thread docs/en/integrations/scylladb/tools/_index.md Outdated
Comment thread docs/en/integrations/scylladb/tools/_index.md Outdated
Comment thread docs/en/integrations/scylladb/tools/scylladb-cql.md
Comment thread docs/en/integrations/scylladb/source.md
Comment thread internal/sources/scylladb/scylladb.go
Comment thread internal/sources/scylladb/scylladb.go
Comment thread internal/sources/scylladb/scylladb.go
Comment thread go.mod
modernc.org/sqlite v1.48.2
)

replace github.com/gocql/gocql => github.com/scylladb/gocql v1.17.3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just do import github.com/scylladb/gocql within the packages instead? That way, we won't have to use the replace directive incase it causes a problem to other sources in the future.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuan325 Unfortunately replace is the only way now. In the next major version of the scylla driver it will be fixed. Is this a blocker?

@zseta
Copy link
Copy Markdown
Author

zseta commented May 7, 2026

Thanks for the comments @Yuan325 I resolved most of the issues. The only problem is with importing (#3119 (comment)). I hope it's not a blocker, if it is then we will need to wait for a fix on our end before merging this.

I also edited the integration test so it uses containers - couldn't run it though so please check.

@zseta zseta requested a review from Yuan325 May 7, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[source] Add source/tool for ScyllaDB

2 participants