feat(scylladb): adding support for ScyllaDB source and tool#3119
feat(scylladb): adding support for ScyllaDB source and tool#3119zseta wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for ScyllaDB as a data source and provides a ScyllaDB CQL tool. It includes the necessary CI configuration, source and tool implementations, unit tests, and integration tests. Feedback focuses on improving JSON serialization consistency by initializing slices, adopting modern Go "any" syntax, enhancing error messages for query failures, and simplifying internal interfaces by removing unused methods.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
hi @Yuan325 , can i get some guidance regarding this PR? |
| modernc.org/sqlite v1.48.2 | ||
| ) | ||
|
|
||
| replace github.com/gocql/gocql => github.com/scylladb/gocql v1.17.3 |
There was a problem hiding this comment.
Can we just do import github.com/scylladb/gocql within the packages instead? That way, we won't have to use the replace directive incase it causes a problem to other sources in the future.
There was a problem hiding this comment.
@Yuan325 Unfortunately replace is the only way now. In the next major version of the scylla driver it will be fixed. Is this a blocker?
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
…into feat-scylladb
|
Thanks for the comments @Yuan325 I resolved most of the issues. The only problem is with importing (#3119 (comment)). I hope it's not a blocker, if it is then we will need to wait for a fix on our end before merging this. I also edited the integration test so it uses containers - couldn't run it though so please check. |
Description
Adds support for ScyllaDB source and tool using the ScyllaDB Go driver.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #3117