docs: Add Announcement Banner Configuration#3532
Merged
Merged
Conversation
Fix missing newline at the end of migration-banner.js
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the hardcoded migration banner with a configurable announcement banner that includes a close button and session-based persistence. Feedback on these changes highlights a potential DOM-based XSS vulnerability in custom-layout.js due to the use of innerHTML with configuration values, suggesting a refactor to use safer DOM APIs like textContent. Additionally, it is recommended to add disableBanner = true to the Cloudflare configuration to preserve the previous behavior of keeping the banner disabled by default on Cloudflare Pages.
Yuan325
added
the
do not merge
averikitsch
reviewed
Jul 6, 2026
averikitsch
approved these changes
Jul 6, 2026
averikitsch
added
docs: deploy-preview
github-actions
Bot
removed
the
docs: deploy-preview
Contributor
|
🚀 Cloudflare Preview Ready! 🔎 View Preview: https://pr-3532.toolbox-docs-6xc.pages.dev (Note: Subsequent pushes to this PR will automatically update the preview at this same URL) |
averikitsch
reviewed
Jul 6, 2026
Contributor
|
🧨 Preview deployments removed. Cloudflare Pages environments for |
github-actions Bot
pushed a commit
that referenced
this pull request
Jul 6, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 9d98bd6
github-actions Bot
pushed a commit
to rodineyw/mcp-toolbox
that referenced
this pull request
Jul 6, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 9d98bd6
github-actions Bot
pushed a commit
to Jaleel-zhu/genai-toolbox
that referenced
this pull request
Jul 6, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 9d98bd6
github-actions Bot
pushed a commit
to pepe57/genai-toolbox
that referenced
this pull request
Jul 7, 2026
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user. Before merging, please alter the title, message, linkText and linkURL --------- Co-authored-by: Averi Kitsch <akitsch@google.com> 9d98bd6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a general banner configuration with a sessionStorage to make the banner closable for a session for a user.
Before merging, please alter the title, message, linkText and linkURL