Skip to content

feat(source/odata): Add Odata source and tool#3534

Merged
Yuan325 merged 9 commits into
googleapis:odata-branchfrom
ameya-sap:feat/source-odata
Jul 15, 2026
Merged

feat(source/odata): Add Odata source and tool#3534
Yuan325 merged 9 commits into
googleapis:odata-branchfrom
ameya-sap:feat/source-odata

Conversation

@ameya-sap

Copy link
Copy Markdown

Description

Should include a concise description of the changes (bug or feature), it's
impact, along with a summary of the solution

PR Checklist

Thank you for opening a Pull Request! Before submitting your PR, there are a
few things you can do to make sure it goes smoothly:

  • Make sure you reviewed
    CONTRIBUTING.md
  • Make sure to open an issue as a
    bug/issue
    before writing your code! That way we can discuss the change, evaluate
    designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Make sure to add ! if this involve a breaking change

🛠️ Fixes #<issue_number_goes_here>

@ameya-sap
ameya-sap requested a review from a team as a code owner June 26, 2026 16:18
@averikitsch averikitsch self-assigned this Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for OData integrations, adding a new OData source and tool implementation along with corresponding documentation and tests. The feedback suggests aligning the OData tool implementation with the repository's canonical pattern by embedding tools.ConfigBase and tools.BaseTool[Config] in the configuration and tool structs. Additionally, the reviewer identified redundant code in internal/tools/odata/odata.go, specifically identical branches in a conditional URL assignment and a redundant parameter mapping block for function imports.

Comment thread internal/tools/odata/odata.go
Comment thread internal/tools/odata/odata.go Outdated
Comment thread internal/tools/odata/odata.go Outdated
@Yuan325 Yuan325 removed their assignment Jul 7, 2026
@Yuan325 Yuan325 added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 7, 2026
@Yuan325
Yuan325 changed the base branch from main to odata-branch July 7, 2026 20:46

@Yuan325 Yuan325 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ameya-sap thank you for opening this PR! In addition to the feedbacks, we'll also need to add the integration test step in .ci/integration.cloudbuild.yaml.

I've also created a new branch (odata-branch). We can merge into that branch for now. When we're ready to release this feature, we can merge it into main :)

Comment thread internal/tools/odata/odata.go
Comment thread internal/tools/odata/odata.go Outdated
Comment thread tests/odata/odata_integration_test.go
Comment thread internal/sources/odata/auth.go
Comment thread internal/sources/odata/odata.go
Comment thread internal/sources/odata/odata_test.go Outdated
Comment thread internal/sources/odata/odata_test.go Outdated
Comment thread internal/sources/odata/auth.go
Comment thread internal/sources/odata/sap_gateway_strategy.go
Comment thread internal/tools/odata/odata_test.go Outdated
Comment thread internal/tools/odata/odata.go
Comment thread internal/sources/odata/auth.go
Comment thread .ci/integration.cloudbuild.yaml Outdated
Comment thread .ci/integration.cloudbuild.yaml Outdated
Comment thread internal/sources/odata/odata.go Outdated
@Yuan325
Yuan325 force-pushed the feat/source-odata branch from 957819f to 56a85c3 Compare July 14, 2026 21:34
@Yuan325

Yuan325 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@Yuan325
Yuan325 self-requested a review July 14, 2026 22:05
@Yuan325

Yuan325 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@Yuan325

Yuan325 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@Yuan325 Yuan325 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 15, 2026
@Yuan325
Yuan325 merged commit b2f4cfa into googleapis:odata-branch Jul 15, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants