feat(source/odata): Add Odata source and tool#3534
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for OData integrations, adding a new OData source and tool implementation along with corresponding documentation and tests. The feedback suggests aligning the OData tool implementation with the repository's canonical pattern by embedding tools.ConfigBase and tools.BaseTool[Config] in the configuration and tool structs. Additionally, the reviewer identified redundant code in internal/tools/odata/odata.go, specifically identical branches in a conditional URL assignment and a redundant parameter mapping block for function imports.
There was a problem hiding this comment.
Hi @ameya-sap thank you for opening this PR! In addition to the feedbacks, we'll also need to add the integration test step in .ci/integration.cloudbuild.yaml.
I've also created a new branch (odata-branch). We can merge into that branch for now. When we're ready to release this feature, we can merge it into main :)
957819f to
56a85c3
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>