Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 35ed6f9

Browse files
committed
Add a check to make sure options exist
1 parent 6b3ec13 commit 35ed6f9

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

src/client-side-metrics/exporter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ export class CloudMonitoringExporter extends MetricExporter {
297297

298298
constructor(options: ClientOptions) {
299299
super();
300-
if (options.apiEndpoint) {
300+
if (options && options.apiEndpoint) {
301301
// We want the MetricServiceClient to always hit its default endpoint.
302302
delete options.apiEndpoint;
303303
}

system-test/gcp-metrics-handler.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@ import {
2525
import {Bigtable} from '../src';
2626
import {ResourceMetrics} from '@opentelemetry/sdk-metrics';
2727
import * as assert from 'assert';
28-
import {
29-
expectedOtelExportInput,
30-
expectedOtelHundredExportInputs,
31-
} from '../test-common/expected-otel-export-input';
32-
import {replaceTimestamps} from '../test-common/replace-timestamps';
3328
import {ClientOptions} from 'google-gax';
3429
import * as proxyquire from 'proxyquire';
3530

@@ -122,7 +117,7 @@ describe('Bigtable/GCPMetricsHandler', () => {
122117
}
123118
}
124119
})().catch(err => {
125-
throw err;
120+
done(err);
126121
});
127122
});
128123
it('Should export a value to two GCPMetricsHandlers', done => {
@@ -224,7 +219,7 @@ describe('Bigtable/GCPMetricsHandler', () => {
224219
}
225220
}
226221
})().catch(err => {
227-
throw err;
222+
done(err);
228223
});
229224
});
230225
it('Should write two duplicate points inserted into the metrics handler', done => {
@@ -305,7 +300,7 @@ describe('Bigtable/GCPMetricsHandler', () => {
305300
}
306301
}
307302
})().catch(err => {
308-
throw err;
303+
done(err);
309304
});
310305
});
311306
});

0 commit comments

Comments
 (0)