Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

Commit 4bb14d6

Browse files
danieljbrucekevkim-codesgcf-owl-bot[bot]
authored
chore(testproxy): Resolve the TestMutateRows_Generic_CloseClient conformance test (#1559)
* Test proxy should not mask error sent back * chore(testproxy): Resolve the TestMutateRows_Generic_CloseClient conformance test * Address the known failure * Add the generic close client known failure back * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Kevin Kim <kevkim@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent d9bed34 commit 4bb14d6

4 files changed

Lines changed: 3 additions & 4 deletions

File tree

protos/protos.d.ts

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protos/protos.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

testproxy/known_failures.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
TestMutateRow_Generic_DeadlineExceeded\|
22
TestMutateRow_Generic_CloseClient\|
3-
TestMutateRows_Generic_CloseClient\|
43
TestMutateRows_Retry_WithRoutingCookie\|
54
TestReadRow_Generic_DeadlineExceeded\|
65
TestReadRow_Retry_WithRoutingCookie\|

testproxy/services/bulk-mutate-rows.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const bulkMutateRows = ({clientMap}) =>
4848
: [];
4949
return {
5050
status: {
51-
code: error.code,
51+
code: error.code ? error.code : grpc.status.UNKNOWN,
5252
details: [],
5353
message: error.message,
5454
},

0 commit comments

Comments
 (0)