Skip to content

Commit 22fa1fe

Browse files
sararobcopybara-github
authored andcommitted
chore: GenAI SDK client - Add more types coverage for Agent Engines replay tests
PiperOrigin-RevId: 781984631
1 parent bcdf041 commit 22fa1fe

7 files changed

Lines changed: 99 additions & 21 deletions

tests/unit/vertexai/genai/replays/test_create_agent_engine_memory.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,21 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
1819

1920

2021
def test_create_memory(client):
2122
agent_engine = client.agent_engines.create()
23+
assert isinstance(agent_engine, types.AgentEngine)
24+
assert isinstance(agent_engine.api_resource, types.ReasoningEngine)
25+
2226
operation = client.agent_engines.create_memory(
2327
name=agent_engine.api_resource.name,
2428
fact="memory_fact",
2529
scope={"user_id": "123"},
30+
config=types.AgentEngineMemoryConfig(display_name="my_memory_fact"),
2631
)
32+
assert isinstance(operation, types.AgentEngineMemoryOperation)
2733
assert operation.response.fact == "memory_fact"
2834
assert operation.response.scope == {"user_id": "123"}
2935
assert operation.response.name.startswith(agent_engine.api_resource.name)

tests/unit/vertexai/genai/replays/test_delete_agent_engine_memory.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
1819

1920

2021
def test_delete_memory(client):
@@ -26,6 +27,7 @@ def test_delete_memory(client):
2627
)
2728
memory = operation.response
2829
operation = client.agent_engines.delete_memory(name=memory.name)
30+
assert isinstance(operation, types.DeleteAgentEngineMemoryOperation)
2931
assert operation.name.startswith(memory.name + "/operations/")
3032

3133

tests/unit/vertexai/genai/replays/test_generate_agent_engine_memories.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
1819

1920

2021
def test_generate_memories(client):
@@ -26,19 +27,21 @@ def test_generate_memories(client):
2627
)
2728
client.agent_engines.generate_memories(
2829
name=agent_engine.api_resource.name,
29-
direct_contents_source={
30-
"events": [
31-
{
32-
"content": {
33-
"role": "model",
34-
"parts": [
35-
{"text": "I am a software engineer focusing in security"}
30+
scope={"user_id": "test-user-id"},
31+
direct_contents_source=types.GenerateMemoriesRequestDirectContentsSource(
32+
events=[
33+
types.GenerateMemoriesRequestDirectContentsSourceEvent(
34+
content=types.Content(
35+
role="model",
36+
parts=[
37+
types.Part(
38+
text="I am a software engineer focusing in security"
39+
)
3640
],
37-
}
38-
}
41+
)
42+
)
3943
]
40-
},
41-
scope={"user_id": "test-user-id"},
44+
),
4245
)
4346
assert (
4447
len(

tests/unit/vertexai/genai/replays/test_get_agent_engine_memory.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
1819

1920

2021
def test_get_memory(client):
@@ -24,9 +25,11 @@ def test_get_memory(client):
2425
fact="memory_fact",
2526
scope={"user_id": "123"},
2627
)
28+
assert isinstance(operation, types.AgentEngineMemoryOperation)
2729
memory = client.agent_engines.get_memory(
2830
name=operation.response.name,
2931
)
32+
assert isinstance(memory, types.Memory)
3033
assert memory.name == operation.response.name
3134

3235

tests/unit/vertexai/genai/replays/test_list_agent_engine_memories.py

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
1819

1920

2021
def test_list_memories(client):
@@ -29,16 +30,11 @@ def test_list_memories(client):
2930
fact="memory_fact",
3031
scope={"user_id": "123"},
3132
)
32-
assert (
33-
len(
34-
list(
35-
client.agent_engines.list_memories(
36-
name=agent_engine.api_resource.name,
37-
)
38-
)
39-
)
40-
== 1
33+
memory_list = client.agent_engines.list_memories(
34+
name=agent_engine.api_resource.name,
4135
)
36+
assert len(memory_list) == 1
37+
assert isinstance(memory_list[0], types.Memory)
4238

4339

4440
pytestmark = pytest_helper.setup(

tests/unit/vertexai/genai/replays/test_retrieve_agent_engine_memories.py

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,19 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18+
from vertexai._genai import types
19+
from google.genai import pagers
1820

1921

20-
def test_retrieve_memories(client):
22+
def test_retrieve_memories_with_similarity_search_params(client):
2123
agent_engine = client.agent_engines.create()
2224
assert not list(
2325
client.agent_engines.retrieve_memories(
2426
name=agent_engine.api_resource.name,
2527
scope={"user_id": "123"},
28+
similarity_search_params=types.RetrieveMemoriesRequestSimilaritySearchParams(
29+
search_query="memory_fact_1",
30+
),
2631
)
2732
)
2833
client.agent_engines.create_memory(
@@ -65,6 +70,25 @@ def test_retrieve_memories(client):
6570
)
6671

6772

73+
def test_retrieve_memories_with_simple_retrieval_params(client):
74+
agent_engine = client.agent_engines.create()
75+
client.agent_engines.create_memory(
76+
name=agent_engine.api_resource.name,
77+
fact="memory_fact_1",
78+
scope={"user_id": "123"},
79+
)
80+
memories = client.agent_engines.retrieve_memories(
81+
name=agent_engine.api_resource.name,
82+
scope={"user_id": "123"},
83+
simple_retrieval_params=types.RetrieveMemoriesRequestSimpleRetrievalParams(
84+
page_size=1,
85+
),
86+
)
87+
assert isinstance(memories, pagers.Pager)
88+
assert isinstance(memories.page[0], types.RetrieveMemoriesResponseRetrievedMemory)
89+
assert memories.page_size == 1
90+
91+
6892
pytestmark = pytest_helper.setup(
6993
file=__file__,
7094
globals_for_file=globals(),
Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
# Copyright 2025 Google LLC
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
#
15+
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
16+
17+
18+
from tests.unit.vertexai.genai.replays import pytest_helper
19+
from vertexai._genai import types
20+
21+
22+
def test_agent_engines_update(client):
23+
agent_engine = client.agent_engines.create()
24+
assert agent_engine.api_resource.display_name is None
25+
26+
updated_agent_engine = client.agent_engines.update(
27+
name=agent_engine.api_resource.name,
28+
config=types.AgentEngineConfig(
29+
display_name="updated_display_name",
30+
description="updated description",
31+
),
32+
)
33+
assert isinstance(updated_agent_engine, types.AgentEngine)
34+
assert updated_agent_engine.api_resource.name == agent_engine.api_resource.name
35+
36+
assert updated_agent_engine.api_resource.display_name == "updated_display_name"
37+
assert updated_agent_engine.api_resource.description == "updated description"
38+
39+
40+
pytestmark = pytest_helper.setup(
41+
file=__file__,
42+
globals_for_file=globals(),
43+
test_method="agent_engines.update",
44+
)

0 commit comments

Comments
 (0)