Skip to content

Commit 4b88698

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
feat: Improve PersistentResource exception logging to include cluster name
PiperOrigin-RevId: 785528276
1 parent c19209d commit 4b88698

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

google/cloud/aiplatform/vertex_ray/util/_gapic_utils.py

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,21 +107,33 @@ def get_persistent_resource(
107107
response = None
108108
if num_attempts >= tolerance:
109109
raise ValueError(
110-
"[Ray on Vertex AI]: Invalid cluster_resource_name (404 not found)."
110+
"[Ray on Vertex AI]: Invalid cluster_resource_name %s (404 not"
111+
" found)." % persistent_resource_name
111112
)
112113
if response:
113114
if response.error.message:
114-
logging.error("[Ray on Vertex AI]: %s" % response.error.message)
115-
raise RuntimeError("[Ray on Vertex AI]: Cluster returned an error.")
115+
logging.error(
116+
"[Ray on Vertex AI]: %s - %s",
117+
persistent_resource_name,
118+
response.error.message,
119+
)
120+
raise RuntimeError(
121+
"[Ray on Vertex AI]: Cluster %s returned an error."
122+
% persistent_resource_name
123+
)
116124

117125
print("[Ray on Vertex AI]: Cluster State =", response.state)
118126
if response.state == PersistentResource.State.RUNNING:
119127
return response
120128
elif response.state == PersistentResource.State.STOPPING:
121-
raise RuntimeError("[Ray on Vertex AI]: The cluster is stopping.")
129+
raise RuntimeError(
130+
"[Ray on Vertex AI]: Cluster %s is stopping."
131+
% persistent_resource_name
132+
)
122133
elif response.state == PersistentResource.State.ERROR:
123134
raise RuntimeError(
124-
"[Ray on Vertex AI]: The cluster encountered an error."
135+
"[Ray on Vertex AI]: Cluster %s encountered an error."
136+
% persistent_resource_name
125137
)
126138
# Polling decay
127139
sleep_time = polling_delay(num_attempts=num_attempts, time_scale=150.0)

tests/unit/vertex_ray/test_ray_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def test_get_persistent_resource_stopping(self, persistent_client_stopping_mock)
3434
)
3535

3636
persistent_client_stopping_mock.assert_called_once()
37-
e.match(regexp=r"The cluster is stopping.")
37+
e.match(regexp=r"Cluster .* is stopping.")
3838

3939
def test_get_persistent_resource_error(self, persistent_client_error_mock):
4040
with pytest.raises(RuntimeError) as e:
@@ -43,4 +43,4 @@ def test_get_persistent_resource_error(self, persistent_client_error_mock):
4343
)
4444

4545
persistent_client_error_mock.assert_called_once()
46-
e.match(regexp=r"The cluster encountered an error.")
46+
e.match(regexp=r"Cluster .* encountered an error.")

0 commit comments

Comments
 (0)