Skip to content

Commit 5f7a998

Browse files
committed
Add list method and fix utils
1 parent a9a8e6e commit 5f7a998

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

google/cloud/aiplatform/pipeline_jobs.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,9 @@ class PipelineJob(base.VertexAiResourceNounWithFutureManager):
8181
_is_client_prediction_client = False
8282

8383
_resource_noun = "pipelineJobs"
84-
_getter_method = "get_pipeline_job"
8584
_delete_method = "delete_pipeline_job"
85+
_getter_method = "get_pipeline_job"
86+
_list_method = "list_pipeline_jobs"
8687

8788
def __init__(
8889
self,

google/cloud/aiplatform/utils/pipeline_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ def from_job_spec_json(
6565
)
6666
parameter_types = {k: v["type"] for k, v in parameter_input_definitions.items()}
6767

68-
pipeline_root = runtime_config_spec.get("gcsOutputDirectory")
68+
pipeline_root = runtime_config_spec.get("gcs_output_directory")
6969
parameter_values = _parse_runtime_parameters(runtime_config_spec)
7070
return cls(pipeline_root, parameter_types, parameter_values)
7171

tests/unit/aiplatform/test_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ class TestPipelineUtils:
360360
}
361361
},
362362
"runtimeConfig": {
363-
"gcsOutputDirectory": "path/to/my/root",
363+
"gcs_output_directory": "path/to/my/root",
364364
"parameters": {
365365
"string_param": {"stringValue": "test-string"},
366366
"int_param": {"intValue": 42},
@@ -420,7 +420,7 @@ def test_pipeline_utils_runtime_config_builder_with_merge_updates(self):
420420
actual_runtime_config = my_builder.build()
421421

422422
expected_runtime_config = {
423-
"gcsOutputDirectory": "path/to/my/new/root",
423+
"gcs_output_directory": "path/to/my/new/root",
424424
"parameters": {
425425
"string_param": {"stringValue": "test-string"},
426426
"int_param": {"intValue": 888},

0 commit comments

Comments
 (0)