Skip to content

Commit 79d8e1c

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
feat: GenAI Client(evals): Add candidate name to local ADK agent scraping
PiperOrigin-RevId: 881533088
1 parent 2b0a98c commit 79d8e1c

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

tests/unit/vertexai/genai/replays/test_evaluate_instances.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ def test_run_inference_with_agent(client):
180180
agent="projects/977012026409/locations/us-central1/reasoningEngines/7188347537655332864",
181181
src=test_df,
182182
)
183-
assert inference_result.candidate_name is None
183+
assert inference_result.candidate_name == "agent_engine_0"
184184
assert inference_result.gcs_source is None
185185

186186

tests/unit/vertexai/genai/test_evals.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1236,7 +1236,7 @@ def test_run_inference_with_agent_engine_and_session_inputs_dict(
12361236
}
12371237
),
12381238
)
1239-
assert inference_result.candidate_name is None
1239+
assert inference_result.candidate_name == "agent_engine_0"
12401240
assert inference_result.gcs_source is None
12411241

12421242
@mock.patch.object(_evals_utils, "EvalDatasetLoader")
@@ -1315,7 +1315,7 @@ def test_run_inference_with_agent_engine_and_session_inputs_literal_string(
13151315
}
13161316
),
13171317
)
1318-
assert inference_result.candidate_name is None
1318+
assert inference_result.candidate_name == "agent_engine_0"
13191319
assert inference_result.gcs_source is None
13201320

13211321
@mock.patch.object(_evals_utils, "EvalDatasetLoader")
@@ -1499,7 +1499,7 @@ def run_async_side_effect(*args, **kwargs):
14991499
),
15001500
expected_df.sort_values(by="prompt").reset_index(drop=True),
15011501
)
1502-
assert inference_result.candidate_name is None
1502+
assert inference_result.candidate_name == "mock_agent"
15031503
assert inference_result.gcs_source is None
15041504

15051505
def test_run_inference_with_litellm_string_prompt_format(

vertexai/_genai/_evals_common.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,6 +1143,13 @@ def _execute_inference(
11431143
candidate_name=candidate_name,
11441144
)
11451145
elif agent_engine or agent:
1146+
candidate_name = None
1147+
if agent_engine:
1148+
candidate_name = "agent_engine_0"
1149+
elif agent:
1150+
agent_config = types.evals.AgentConfig.from_agent(agent)
1151+
candidate_name = agent_config.agent_id or "agent_0"
1152+
11461153
if (
11471154
agent_engine
11481155
and not isinstance(agent_engine, str)
@@ -1181,6 +1188,7 @@ def _execute_inference(
11811188

11821189
evaluation_dataset = types.EvaluationDataset(
11831190
eval_dataset_df=results_df,
1191+
candidate_name=candidate_name,
11841192
)
11851193
else:
11861194
raise ValueError("Either model, agent_engine or agent must be provided.")

0 commit comments

Comments
 (0)