Skip to content

Commit 7de7acc

Browse files
vertex-sdk-botcopybara-github
vertex-sdk-bot
authored and
copybara-github
committed
chore: rename "AgentEngine" to "Runtime" in Feedback Entry SDK modules.
PiperOrigin-RevId: 945880554
1 parent f5f750c commit 7de7acc

10 files changed

Lines changed: 540 additions & 522 deletions

‎agentplatform/_genai/feedback_contexts.py‎

Lines changed: 79 additions & 79 deletions
Large diffs are not rendered by default.

‎agentplatform/_genai/feedback_entries.py‎

Lines changed: 170 additions & 170 deletions
Large diffs are not rendered by default.

‎agentplatform/_genai/types/__init__.py‎

Lines changed: 92 additions & 86 deletions
Large diffs are not rendered by default.

‎agentplatform/_genai/types/common.py‎

Lines changed: 163 additions & 147 deletions
Large diffs are not rendered by default.

‎tests/unit/agentplatform/genai/replays/test_create_feedback_entry.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ def test_create(client):
4242
session_id="session_123",
4343
event_id="event_456",
4444
feedback_type=types.FeedbackType.THUMBS_UP,
45-
config=types.CreateAgentEngineFeedbackEntryConfig(
45+
config=types.CreateRuntimeFeedbackEntryConfig(
4646
feedback_text="Great response!",
4747
feedback_labels=["incomplete", "inaccurate"],
4848
user_id="user_789",
4949
source="Test IDE",
5050
custom_metadata={"key1": "val1", "key2": "val2"},
5151
),
5252
)
53-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
53+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
5454
assert operation.done
5555

5656
assert operation.response is not None
@@ -86,15 +86,15 @@ async def test_create_async(client):
8686
session_id="session_123",
8787
event_id="event_456",
8888
feedback_type=types.FeedbackType.THUMBS_UP,
89-
config=types.CreateAgentEngineFeedbackEntryConfig(
89+
config=types.CreateRuntimeFeedbackEntryConfig(
9090
feedback_text="Great response!",
9191
feedback_labels=["incomplete", "inaccurate"],
9292
user_id="user_789",
9393
source="Test IDE",
9494
custom_metadata={"key1": "val1", "key2": "val2"},
9595
),
9696
)
97-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
97+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
9898
assert operation.done
9999

100100
assert operation.response is not None

‎tests/unit/agentplatform/genai/replays/test_delete_feedback_entry.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def test_delete(client):
5151
)
5252
assert isinstance(
5353
delete_operation,
54-
types.DeleteAgentEngineFeedbackEntryOperation,
54+
types.DeleteRuntimeFeedbackEntryOperation,
5555
)
5656
assert delete_operation.done
5757

@@ -85,7 +85,7 @@ async def test_delete_async(client):
8585
)
8686
assert isinstance(
8787
delete_operation,
88-
types.DeleteAgentEngineFeedbackEntryOperation,
88+
types.DeleteRuntimeFeedbackEntryOperation,
8989
)
9090

9191
with pytest.raises(errors.ClientError, match="404 NOT_FOUND"):

‎tests/unit/agentplatform/genai/replays/test_get_feedback_entry.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ def test_get(client):
4242
session_id="session_123",
4343
event_id="event_456",
4444
feedback_type=types.FeedbackType.THUMBS_UP,
45-
config=types.CreateAgentEngineFeedbackEntryConfig(
45+
config=types.CreateRuntimeFeedbackEntryConfig(
4646
feedback_text="Great response!",
4747
feedback_labels=["incomplete", "inaccurate"],
4848
user_id="user_789",
4949
source="Test IDE",
5050
custom_metadata={"key1": "val1", "key2": "val2"},
5151
),
5252
)
53-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
53+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
5454
assert operation.done
5555

5656
feedback = client.feedback_entries.get(name=operation.response.name)
@@ -81,15 +81,15 @@ async def test_get_async(client):
8181
session_id="session_123",
8282
event_id="event_456",
8383
feedback_type=types.FeedbackType.THUMBS_UP,
84-
config=types.CreateAgentEngineFeedbackEntryConfig(
84+
config=types.CreateRuntimeFeedbackEntryConfig(
8585
feedback_text="Great response!",
8686
feedback_labels=["incomplete", "inaccurate"],
8787
user_id="user_789",
8888
source="Test IDE",
8989
custom_metadata={"key1": "val1", "key2": "val2"},
9090
),
9191
)
92-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
92+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
9393
assert operation.done
9494

9595
feedback = await client.aio.feedback_entries.get(name=operation.response.name)

‎tests/unit/agentplatform/genai/replays/test_list_feedback_entries.py‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@ def test_list(client):
4343
session_id="session_123",
4444
event_id="event_456",
4545
feedback_type=types.FeedbackType.THUMBS_UP,
46-
config=types.CreateAgentEngineFeedbackEntryConfig(
46+
config=types.CreateRuntimeFeedbackEntryConfig(
4747
feedback_text="Great response!",
4848
feedback_labels=["incomplete", "inaccurate"],
4949
user_id="user_789",
5050
source="Test IDE",
5151
custom_metadata={"key1": "val1", "key2": "val2"},
5252
),
5353
)
54-
assert isinstance(operation_up, types.AgentEngineFeedbackEntryOperation)
54+
assert isinstance(operation_up, types.RuntimeFeedbackEntryOperation)
5555
assert operation_up.done
5656

5757
# Create THUMBS_DOWN feedback entry.
@@ -60,15 +60,15 @@ def test_list(client):
6060
session_id="session_abc",
6161
event_id="event_xyz",
6262
feedback_type=types.FeedbackType.THUMBS_DOWN,
63-
config=types.CreateAgentEngineFeedbackEntryConfig(
63+
config=types.CreateRuntimeFeedbackEntryConfig(
6464
feedback_text="Response was incorrect.",
6565
feedback_labels=["off_topic", "hallucination"],
6666
user_id="user_789",
6767
source="Test IDE",
6868
custom_metadata={"key_a": "val_a"},
6969
),
7070
)
71-
assert isinstance(operation_down, types.AgentEngineFeedbackEntryOperation)
71+
assert isinstance(operation_down, types.RuntimeFeedbackEntryOperation)
7272
assert operation_down.done
7373

7474
# List and verify the feedback entries.
@@ -123,15 +123,15 @@ async def test_list_async(client):
123123
session_id="session_123",
124124
event_id="event_456",
125125
feedback_type=types.FeedbackType.THUMBS_UP,
126-
config=types.CreateAgentEngineFeedbackEntryConfig(
126+
config=types.CreateRuntimeFeedbackEntryConfig(
127127
feedback_text="Great response!",
128128
feedback_labels=["incomplete", "inaccurate"],
129129
user_id="user_789",
130130
source="Test IDE",
131131
custom_metadata={"key1": "val1", "key2": "val2"},
132132
),
133133
)
134-
assert isinstance(operation_up, types.AgentEngineFeedbackEntryOperation)
134+
assert isinstance(operation_up, types.RuntimeFeedbackEntryOperation)
135135
assert operation_up.done
136136

137137
# Create THUMBS_DOWN feedback entry.
@@ -140,15 +140,15 @@ async def test_list_async(client):
140140
session_id="session_abc",
141141
event_id="event_xyz",
142142
feedback_type=types.FeedbackType.THUMBS_DOWN,
143-
config=types.CreateAgentEngineFeedbackEntryConfig(
143+
config=types.CreateRuntimeFeedbackEntryConfig(
144144
feedback_text="Response was incorrect.",
145145
feedback_labels=["off_topic", "hallucination"],
146146
user_id="user_789",
147147
source="Test IDE",
148148
custom_metadata={"key_a": "val_a"},
149149
),
150150
)
151-
assert isinstance(operation_down, types.AgentEngineFeedbackEntryOperation)
151+
assert isinstance(operation_down, types.RuntimeFeedbackEntryOperation)
152152
assert operation_down.done
153153

154154
# List and verify the feedback entries.

‎tests/unit/agentplatform/genai/replays/test_update_feedback_context.py‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def test_update_and_get(client):
5656
],
5757
)
5858

59-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
59+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
6060
assert update_operation.done
6161

6262
updated_context = update_operation.response
@@ -91,7 +91,7 @@ def test_update_and_get(client):
9191
),
9292
],
9393
)
94-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
94+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
9595
assert update_operation.done
9696

9797
updated_context = update_operation.response
@@ -102,7 +102,7 @@ def test_update_and_get(client):
102102
parent=feedback_entry.name,
103103
context_events=[],
104104
)
105-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
105+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
106106
assert update_operation.done
107107

108108
updated_context = update_operation.response
@@ -141,7 +141,7 @@ async def test_update_and_get_async(client):
141141
],
142142
)
143143

144-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
144+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
145145
assert update_operation.done
146146

147147
updated_context = update_operation.response
@@ -176,7 +176,7 @@ async def test_update_and_get_async(client):
176176
),
177177
],
178178
)
179-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
179+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
180180
assert update_operation.done
181181

182182
updated_context = update_operation.response
@@ -187,7 +187,7 @@ async def test_update_and_get_async(client):
187187
parent=feedback_entry.name,
188188
context_events=[],
189189
)
190-
assert isinstance(update_operation, types.AgentEngineFeedbackContextOperation)
190+
assert isinstance(update_operation, types.RuntimeFeedbackContextOperation)
191191
assert update_operation.done
192192

193193
updated_context = update_operation.response

‎tests/unit/agentplatform/genai/replays/test_update_feedback_entry.py‎

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ def test_update(client):
4242
session_id="session_123",
4343
event_id="event_456",
4444
feedback_type=types.FeedbackType.THUMBS_UP,
45-
config=types.CreateAgentEngineFeedbackEntryConfig(
45+
config=types.CreateRuntimeFeedbackEntryConfig(
4646
feedback_text="Great response!",
4747
feedback_labels=["incomplete"],
4848
user_id="user_789",
4949
source="Test IDE",
5050
custom_metadata={"key1": "val1", "key2": "val2"},
5151
),
5252
)
53-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
53+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
5454
assert operation.done
5555

5656
assert operation.response is not None
@@ -60,7 +60,7 @@ def test_update(client):
6060

6161
update_operation = client.feedback_entries.update(
6262
name=feedback_entry.name,
63-
config=types.UpdateAgentEngineFeedbackEntryConfig(
63+
config=types.UpdateRuntimeFeedbackEntryConfig(
6464
update_mask="feedbackType,feedbackText,feedbackLabels,userId,source,customMetadata",
6565
feedback_type=types.FeedbackType.THUMBS_DOWN,
6666
feedback_text="Actually bad response!",
@@ -71,7 +71,7 @@ def test_update(client):
7171
),
7272
)
7373

74-
assert isinstance(update_operation, types.AgentEngineFeedbackEntryOperation)
74+
assert isinstance(update_operation, types.RuntimeFeedbackEntryOperation)
7575
assert update_operation.done
7676

7777
updated_feedback = update_operation.response
@@ -89,16 +89,14 @@ def test_update(client):
8989
# Second update: change only session_id and event_id via a scoped mask.
9090
session_update_operation = client.feedback_entries.update(
9191
name=feedback_entry.name,
92-
config=types.UpdateAgentEngineFeedbackEntryConfig(
92+
config=types.UpdateRuntimeFeedbackEntryConfig(
9393
update_mask="sessionId,eventId",
9494
session_id="session_new_456",
9595
event_id="event_new_789",
9696
),
9797
)
9898

99-
assert isinstance(
100-
session_update_operation, types.AgentEngineFeedbackEntryOperation
101-
)
99+
assert isinstance(session_update_operation, types.RuntimeFeedbackEntryOperation)
102100
assert session_update_operation.done
103101

104102
session_updated_feedback = session_update_operation.response
@@ -133,15 +131,15 @@ async def test_update_async(client):
133131
session_id="session_123",
134132
event_id="event_456",
135133
feedback_type=types.FeedbackType.THUMBS_UP,
136-
config=types.CreateAgentEngineFeedbackEntryConfig(
134+
config=types.CreateRuntimeFeedbackEntryConfig(
137135
feedback_text="Great response!",
138136
feedback_labels=["incomplete"],
139137
user_id="user_789",
140138
source="Test IDE",
141139
custom_metadata={"key1": "val1", "key2": "val2"},
142140
),
143141
)
144-
assert isinstance(operation, types.AgentEngineFeedbackEntryOperation)
142+
assert isinstance(operation, types.RuntimeFeedbackEntryOperation)
145143
assert operation.done
146144

147145
assert operation.response is not None
@@ -151,7 +149,7 @@ async def test_update_async(client):
151149

152150
update_operation = await client.aio.feedback_entries.update(
153151
name=feedback_entry.name,
154-
config=types.UpdateAgentEngineFeedbackEntryConfig(
152+
config=types.UpdateRuntimeFeedbackEntryConfig(
155153
update_mask="feedbackType,feedbackText,feedbackLabels,userId,source,customMetadata",
156154
feedback_type=types.FeedbackType.THUMBS_DOWN,
157155
feedback_text="Actually bad response!",
@@ -162,7 +160,7 @@ async def test_update_async(client):
162160
),
163161
)
164162

165-
assert isinstance(update_operation, types.AgentEngineFeedbackEntryOperation)
163+
assert isinstance(update_operation, types.RuntimeFeedbackEntryOperation)
166164
assert update_operation.done
167165

168166
updated_feedback = update_operation.response
@@ -180,16 +178,14 @@ async def test_update_async(client):
180178
# Second update: change only session_id and event_id via a scoped mask.
181179
session_update_operation = await client.aio.feedback_entries.update(
182180
name=feedback_entry.name,
183-
config=types.UpdateAgentEngineFeedbackEntryConfig(
181+
config=types.UpdateRuntimeFeedbackEntryConfig(
184182
update_mask="sessionId,eventId",
185183
session_id="session_new_456",
186184
event_id="event_new_789",
187185
),
188186
)
189187

190-
assert isinstance(
191-
session_update_operation, types.AgentEngineFeedbackEntryOperation
192-
)
188+
assert isinstance(session_update_operation, types.RuntimeFeedbackEntryOperation)
193189
assert session_update_operation.done
194190

195191
session_updated_feedback = session_update_operation.response

0 commit comments

Comments
 (0)