Skip to content

Commit 9e80e1d

Browse files
vertex-sdk-botcopybara-github
authored andcommitted
chore: Fix type error in _get_default_prompt_template for optional .values
PiperOrigin-RevId: 949036874
1 parent 3335750 commit 9e80e1d

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

agentplatform/_genai/_evals_common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,10 @@ def _get_default_prompt_template(
484484
and eval_item.evaluation_request.prompt
485485
and eval_item.evaluation_request.prompt.prompt_template_data
486486
):
487-
if (
488-
"prompt"
489-
in eval_item.evaluation_request.prompt.prompt_template_data.values
490-
):
487+
template_values = (
488+
eval_item.evaluation_request.prompt.prompt_template_data.values
489+
)
490+
if template_values and "prompt" in template_values:
491491
return "{prompt}"
492492
except Exception as e:
493493
logger.warning("Failed to get prompt template from evaluation set: %s", e)

vertexai/_genai/_evals_common.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,10 +469,10 @@ def _get_default_prompt_template(
469469
and eval_item.evaluation_request.prompt
470470
and eval_item.evaluation_request.prompt.prompt_template_data
471471
):
472-
if (
473-
"prompt"
474-
in eval_item.evaluation_request.prompt.prompt_template_data.values
475-
):
472+
template_values = (
473+
eval_item.evaluation_request.prompt.prompt_template_data.values
474+
)
475+
if template_values and "prompt" in template_values:
476476
return "{prompt}"
477477
except Exception as e:
478478
logger.warning("Failed to get prompt template from evaluation set: %s", e)

0 commit comments

Comments
 (0)