Skip to content

Commit fe577ee

Browse files
sararobcopybara-github
authored andcommitted
chore: GenAI SDK client - refactor prompt management operations to use Operation type
PiperOrigin-RevId: 804577329
1 parent c6872f0 commit fe577ee

5 files changed

Lines changed: 91 additions & 310 deletions

File tree

tests/unit/vertexai/genai/replays/test_create_prompt.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@
8080

8181
def test_create_dataset(client):
8282
create_dataset_operation = client.prompt_management._create_dataset_resource(
83-
config=types.CreateDatasetConfig(should_return_http_response=True),
8483
name="projects/vertex-sdk-dev/locations/us-central1",
8584
display_name="test display name",
8685
metadata_schema_uri="gs://google-cloud-aiplatform/schema/dataset/metadata/text_prompt_1.0.0.yaml",
@@ -123,8 +122,8 @@ def test_create_dataset(client):
123122
},
124123
model_reference="gemini-2.0-flash-001",
125124
)
126-
assert isinstance(create_dataset_operation, types.CreateDatasetOperationMetadata)
127-
assert create_dataset_operation.sdk_http_response.body is not None
125+
assert isinstance(create_dataset_operation, types.DatasetOperation)
126+
assert create_dataset_operation
128127

129128

130129
def test_create_dataset_version(client):
@@ -134,9 +133,7 @@ def test_create_dataset_version(client):
134133
display_name="my new version yay",
135134
)
136135
)
137-
assert isinstance(
138-
dataset_version_resource, types.CreateDatasetVersionOperationMetadata
139-
)
136+
assert isinstance(dataset_version_resource, types.DatasetOperation)
140137

141138

142139
def test_create_version_e2e(client):

tests/unit/vertexai/genai/replays/test_get_prompt_operation.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,14 @@
1515
# pylint: disable=protected-access,bad-continuation,missing-function-docstring
1616

1717
from tests.unit.vertexai.genai.replays import pytest_helper
18-
from vertexai._genai import types
1918

2019

2120
def test_get_dataset_operation(client):
2221
dataset_operation = client.prompt_management._get_dataset_operation(
23-
config=types.GetDatasetOperationConfig(should_return_http_response=True),
2422
dataset_id="6550997480673116160",
2523
operation_id="5108504762664353792",
2624
)
27-
assert dataset_operation.sdk_http_response.body is not None
25+
assert dataset_operation.name is not None
2826

2927

3028
pytestmark = pytest_helper.setup(

vertexai/_genai/_prompt_management_utils.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#
1515
"""Utility functions for prompt management."""
1616

17-
import json
1817
from typing import Optional
1918

2019
from google.genai import types as genai_types
@@ -78,19 +77,6 @@ def _create_dataset_metadata_from_prompt(
7877
return prompt_metadata
7978

8079

81-
def _check_operation_status_from_response_body(
82-
operation_response: genai_types.HttpResponse,
83-
):
84-
"""Checks the operation status from the response body."""
85-
if not hasattr(operation_response, "body"):
86-
raise ValueError("Error creating prompt dataset resource.")
87-
done = False
88-
body = json.loads(operation_response.body)
89-
if body.get("done"):
90-
done = True
91-
return done
92-
93-
9480
def _create_prompt_from_dataset_metadata(
9581
dataset: types.Dataset,
9682
) -> types.Prompt:

0 commit comments

Comments
 (0)