Skip to content

feat: Add get_iam_policy and set_iam_policy methods to ReasoningEngine. #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+201 −122
Open

feat: Add get_iam_policy and set_iam_policy methods to ReasoningEngine. #6548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions tests/unit/vertex_langchain/test_reasoning_engines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
from vertexai.preview import reasoning_engines
from vertexai.reasoning_engines import _reasoning_engines
from vertexai.reasoning_engines import _utils
from google.iam.v1 import policy_pb2
from google.api import httpbody_pb2
from google.protobuf import field_mask_pb2
from google.protobuf import struct_pb2
Expand Down Expand Up @@ -794,6 +795,46 @@ def test_create_reasoning_engine(
retry=_TEST_RETRY,
)

def test_get_iam_policy(self):
with mock.patch.object(
base.VertexAiResourceNoun, "_get_gca_resource"
) as mock_get_gca_resource:
mock_get_gca_resource.return_value = types.ReasoningEngine(
name=_TEST_REASONING_ENGINE_RESOURCE_NAME
)
reasoning_engine = reasoning_engines.ReasoningEngine(
_TEST_REASONING_ENGINE_RESOURCE_NAME
)

test_policy = policy_pb2.Policy(version=1)
with mock.patch.object(
reasoning_engine.api_client, "get_iam_policy"
) as mock_get_iam_policy:
mock_get_iam_policy.return_value = test_policy
policy = reasoning_engine.get_iam_policy(policy_version=1)
mock_get_iam_policy.assert_called_once()
assert policy == test_policy

def test_set_iam_policy(self):
with mock.patch.object(
base.VertexAiResourceNoun, "_get_gca_resource"
) as mock_get_gca_resource:
mock_get_gca_resource.return_value = types.ReasoningEngine(
name=_TEST_REASONING_ENGINE_RESOURCE_NAME
)
reasoning_engine = reasoning_engines.ReasoningEngine(
_TEST_REASONING_ENGINE_RESOURCE_NAME
)

test_policy = policy_pb2.Policy(version=1)
with mock.patch.object(
reasoning_engine.api_client, "set_iam_policy"
) as mock_set_iam_policy:
mock_set_iam_policy.return_value = test_policy
policy = reasoning_engine.set_iam_policy(test_policy)
mock_set_iam_policy.assert_called_once()
assert policy == test_policy

@pytest.mark.usefixtures("caplog")
def test_create_reasoning_engine_warn_resource_name(
self,
Expand Down
Loading
Loading