Skip to content

Test mtls #6601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agrawalradhika-cell wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Test mtls #6601

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a3a1cc7
chore: make changes for mTLS
agrawalradhika-cell Apr 16, 2026
e670502
chore: Add mtls flag and endpoint transform
agrawalradhika-cell Apr 16, 2026
dcf9605
chore: create PR for checking aiplatform
agrawalradhika-cell Apr 16, 2026
d00514a
Update adk.py
agrawalradhika-cell Apr 17, 2026
15686ed
Delete test-mtls-agentt directory
agrawalradhika-cell Apr 17, 2026
f31c939
Delete test-changes-agent directory
agrawalradhika-cell Apr 17, 2026
71be52c
Update adk.py to check for client_cert_callback
agrawalradhika-cell Apr 17, 2026
4b1eacf
Update adk.py to inclue default_client_cert_source
agrawalradhika-cell Apr 17, 2026
635416b
try option 3 to set cert and key explicilty for Update adk.py
agrawalradhika-cell Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions vertexai/agent_engines/templates/adk.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import asyncio
from collections.abc import Awaitable
import os
import queue
import sys
import threading
Expand Down Expand Up @@ -93,6 +94,7 @@
SynchronousMultiSpanProcessor = Any



_DEFAULT_APP_NAME = "default-app-name"
_DEFAULT_USER_ID = "default-user-id"
_TELEMETRY_API_DISABLED_WARNING = (
Expand Down Expand Up @@ -378,6 +380,7 @@ def _detect_cloud_resource_id(project_id: str) -> Optional[str]:
import opentelemetry.exporter.otlp.proto.http.version
import opentelemetry.exporter.otlp.proto.http.trace_exporter
import google.auth.transport.requests
from google.auth.transport import _mtls_helper
from google.cloud.aiplatform import version as aip_version
except (ImportError, AttributeError):
return _warn_missing_dependency(
Expand All @@ -390,13 +393,18 @@ def _detect_cloud_resource_id(project_id: str) -> Optional[str]:
vertex_sdk_version = aip_version.__version__
otlp_http_version = opentelemetry.exporter.otlp.proto.http.version.__version__
user_agent = f"Vertex-Agent-Engine/{vertex_sdk_version} OTel-OTLP-Exporter-Python/{otlp_http_version}"

session = google.auth.transport.requests.AuthorizedSession(
credentials=credentials
)
_ , cert, key = _mtls_helper.get_client_cert_and_key()
session.configure_mtls_channel(client_cert_callback)
print("configure_mtls_channel done")
span_exporter = (
opentelemetry.exporter.otlp.proto.http.trace_exporter.OTLPSpanExporter(
session=google.auth.transport.requests.AuthorizedSession(
credentials=credentials
),
endpoint="https://telemetry.googleapis.com/v1/traces",
session=session,
endpoint="https://telemetry.mtls.googleapis.com/v1/traces",
client_certificate_file = cert,
client_key_file = key,
headers={"User-Agent": user_agent},
)
)
Expand Down Expand Up @@ -552,8 +560,12 @@ def _warn_if_telemetry_api_disabled():
except (ImportError, AttributeError):
return
credentials, project = google.auth.default()
print("in warn terlemetery before configure mtls")
session = google.auth.transport.requests.AuthorizedSession(credentials=credentials)
r = session.post("https://telemetry.googleapis.com/v1/traces", data=None)
session.configure_mtls_channel()
print("post configure mtls")
r = session.post("https://telemetry.mtls.googleapis.com/v1/traces", data=None)
print("after session post call")
if "Telemetry API has not been used in project" in r.text:
_warn(_TELEMETRY_API_DISABLED_WARNING % (project, project))

Expand Down Expand Up @@ -806,6 +818,7 @@ def set_up(self):
from google.adk.memory.in_memory_memory_service import InMemoryMemoryService

os.environ["GOOGLE_GENAI_USE_VERTEXAI"] = "1"
os.environ["GOOGLE_API_USE_CLIENT_CERTIFICATE"] = "true"
project = self._tmpl_attrs.get("project")
if project:
os.environ["GOOGLE_CLOUD_PROJECT"] = project
Expand Down
Loading