Skip to content

fix: versioning registry location #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
racinmat wants to merge 3 commits into
base: main
Choose a base branch
from
+29 −2
Open

fix: versioning registry location #6641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
062e051
fix: using location and project parsed from resource name if not prov…
racinmat Oct 8, 2023
a07797f
test: versioning registry location
racinmat Apr 24, 2026
7a40c7b
Merge branch 'main' into versioning-registry
racinmat Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/aiplatform/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5240,8 +5240,8 @@ def __init__(
# Create ModelRegistry with the unversioned resource name
self._registry = ModelRegistry(
self.resource_name,
location=location,
project=project,
location=location or self.location,
project=project or self.project,
credentials=credentials,
)

Expand Down
27 changes: 27 additions & 0 deletions tests/unit/aiplatform/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4701,6 +4701,33 @@ def test_init_with_version_arg(self, get_model_with_version):
# The Model yielded from upload SHOULD have a version in the versioned resource name
assert model.versioned_resource_name.endswith(f"@{_TEST_VERSION_ID}")

def test_versioning_registry_uses_location_from_resource_name(
self, create_client_mock
):
# Regression test for https://github.com/googleapis/python-aiplatform/issues/2608:
# When a Model is initialized with a fully-qualified resource name that encodes a
# non-default location, the versioning registry client must use that location, not
# the global default from aiplatform.init().
models.Model(_TEST_MODEL_RESOURCE_NAME_CUSTOM_LOCATION)
create_client_mock.assert_any_call(
client_class=utils.ModelClientWithOverride,
credentials=initializer.global_config.credentials,
location_override=_TEST_LOCATION_2,
appended_user_agent=None,
)

def test_versioning_registry_uses_project_from_resource_name(
self, get_model_with_custom_project_mock
):
# Regression test for https://github.com/googleapis/python-aiplatform/issues/2608:
# When a Model is initialized with a fully-qualified resource name that encodes a
# non-default project, the versioning registry must use that project, not the
# global default from aiplatform.init().
model = models.Model(_TEST_MODEL_RESOURCE_NAME_CUSTOM_PROJECT)
assert model._registry.model_resource_name.startswith(
f"projects/{_TEST_PROJECT_2}/"
)

@pytest.mark.parametrize(
"parent,location,project",
[
Expand Down