update SQLGlot compiler too

Author: sycai

bigframes/core/compile/sqlglot/expressions/datetime_ops.py

@@ -371,7 +371,7 @@ def _(expr: TypedExpr, op: ops.ToDatetimeOp) -> sge.Expression:
         )
         return sge.Cast(this=result, to="DATETIME")
 
-    if expr.dtype == dtypes.STRING_DTYPE:
+    if expr.dtype in (dtypes.STRING_DTYPE, dtypes.TIMESTAMP_DTYPE):
         return sge.TryCast(this=expr.expr, to="DATETIME")
 
     value = expr.expr
@@ -396,7 +396,7 @@ def _(expr: TypedExpr, op: ops.ToTimestampOp) -> sge.Expression:
             "PARSE_TIMESTAMP", sge.convert(op.format), expr.expr, sge.convert("UTC")
         )
 
-    if expr.dtype == dtypes.STRING_DTYPE:
+    if expr.dtype in (dtypes.STRING_DTYPE, dtypes.DATETIME_DTYPE):
         return sge.func("TIMESTAMP", expr.expr)
 
     value = expr.expr

tests/unit/core/compile/sqlglot/expressions/snapshots/test_datetime_ops/test_to_datetime/out.sql

@@ -1,5 +1,6 @@
 SELECT
   CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col` * 0.001) AS INT64)) AS DATETIME) AS `int64_col`,
   SAFE_CAST(`string_col` AS DATETIME),
-  CAST(TIMESTAMP_MICROS(CAST(TRUNC(`float64_col` * 0.001) AS INT64)) AS DATETIME) AS `float64_col`
+  CAST(TIMESTAMP_MICROS(CAST(TRUNC(`float64_col` * 0.001) AS INT64)) AS DATETIME) AS `float64_col`,
+  SAFE_CAST(`timestamp_col` AS DATETIME)
 FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`

tests/unit/core/compile/sqlglot/expressions/snapshots/test_datetime_ops/test_to_timestamp/out.sql

@@ -4,5 +4,6 @@ SELECT
   CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col` * 1000000) AS INT64)) AS TIMESTAMP) AS `int64_col_s`,
   CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col` * 1000) AS INT64)) AS TIMESTAMP) AS `int64_col_ms`,
   CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col`) AS INT64)) AS TIMESTAMP) AS `int64_col_us`,
-  CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col` * 0.001) AS INT64)) AS TIMESTAMP) AS `int64_col_ns`
+  CAST(TIMESTAMP_MICROS(CAST(TRUNC(`int64_col` * 0.001) AS INT64)) AS TIMESTAMP) AS `int64_col_ns`,
+  TIMESTAMP(`datetime_col`) AS `datetime_col`
 FROM `bigframes-dev`.`sqlglot_test`.`scalar_types` AS `bft_0`

tests/unit/core/compile/sqlglot/expressions/test_datetime_ops.py

@@ -180,7 +180,7 @@ def test_time(scalar_types_df: bpd.DataFrame, snapshot):
 
 
 def test_to_datetime(scalar_types_df: bpd.DataFrame, snapshot):
-    col_names = ["int64_col", "string_col", "float64_col"]
+    col_names = ["int64_col", "string_col", "float64_col", "timestamp_col"]
     bf_df = scalar_types_df[col_names]
     ops_map = {col_name: ops.ToDatetimeOp().as_expr(col_name) for col_name in col_names}
 
@@ -189,14 +189,15 @@ def test_to_datetime(scalar_types_df: bpd.DataFrame, snapshot):
 
 
 def test_to_timestamp(scalar_types_df: bpd.DataFrame, snapshot):
-    bf_df = scalar_types_df[["int64_col", "string_col", "float64_col"]]
+    bf_df = scalar_types_df[["int64_col", "string_col", "float64_col", "datetime_col"]]
     ops_map = {
         "int64_col": ops.ToTimestampOp().as_expr("int64_col"),
         "float64_col": ops.ToTimestampOp().as_expr("float64_col"),
         "int64_col_s": ops.ToTimestampOp(unit="s").as_expr("int64_col"),
         "int64_col_ms": ops.ToTimestampOp(unit="ms").as_expr("int64_col"),
         "int64_col_us": ops.ToTimestampOp(unit="us").as_expr("int64_col"),
         "int64_col_ns": ops.ToTimestampOp(unit="ns").as_expr("int64_col"),
+        "datetime_col": ops.ToTimestampOp().as_expr("datetime_col"),
     }
 
     sql = utils._apply_ops_to_sql(bf_df, list(ops_map.values()), list(ops_map.keys()))