fix isin struct ics

Author: TrevorBergeron

bigframes/core/compile/sqlglot/sqlglot_ir.py

@@ -357,8 +357,8 @@ def isin_join(
                 or conditions[1].dtype == dtypes.FLOAT_DTYPE
             ):
                 force_float_domain = True
-            part1_id = sql.identifier(next(self.uid_gen.get_uid_stream("bfpart1_")))
-            part2_id = sql.identifier(next(self.uid_gen.get_uid_stream("bfpart2_")))
+            part1_id = sql.identifier("bfpart1")
+            part2_id = sql.identifier("bfpart2")
             left_expr1, left_expr2 = _value_to_non_null_identity(
                 conditions[0], force_float_domain
             )

tests/unit/core/compile/sqlglot/snapshots/test_compile_isin/test_compile_isin/out.sql

@@ -20,10 +20,10 @@ WITH `bfcte_0` AS (
 ), `bfcte_4` AS (
   SELECT
     *,
-    STRUCT(COALESCE(`bfcol_4`, 0) AS `bfpart1_0`, COALESCE(`bfcol_4`, 1) AS `bfpart2_0`) IN (
+    STRUCT(COALESCE(`bfcol_4`, 0) AS `bfpart1`, COALESCE(`bfcol_4`, 1) AS `bfpart2`) IN (
       (
         SELECT
-          STRUCT(COALESCE(`bfcol_0`, 0) AS `bfpart1_0`, COALESCE(`bfcol_0`, 1) AS `bfpart2_0`)
+          STRUCT(COALESCE(`bfcol_0`, 0) AS `bfpart1`, COALESCE(`bfcol_0`, 1) AS `bfpart2`)
         FROM `bfcte_3`
       )
     ) AS `bfcol_5`

tests/unit/core/compile/sqlglot/snapshots/test_compile_join/test_compile_join_w_on/float64_col/out.sql

@@ -20,5 +20,5 @@ SELECT
   `bfcol_2` AS `rowindex_y`
 FROM `bfcte_2`
 INNER JOIN `bfcte_1`
-  ON IF(IS_NAN(`bfcol_5`), 2, COALESCE(`bfcol_5`, 0)) = IF(IS_NAN(`bfcol_3`), 2, COALESCE(`bfcol_3`, 0))
-  AND IF(IS_NAN(`bfcol_5`), 3, COALESCE(`bfcol_5`, 1)) = IF(IS_NAN(`bfcol_3`), 3, COALESCE(`bfcol_3`, 1))
+  ON IF(IS_NAN(`bfcol_5`), 2.0, COALESCE(`bfcol_5`, 0.0)) = IF(IS_NAN(`bfcol_3`), 2.0, COALESCE(`bfcol_3`, 0.0))
+  AND IF(IS_NAN(`bfcol_5`), 3, COALESCE(`bfcol_5`, 1.0)) = IF(IS_NAN(`bfcol_3`), 3, COALESCE(`bfcol_3`, 1.0))