refactor: fix pull_up_select disorder the columns of readtable nodes

Author: chelsea-lin

bigframes/core/rewrite/select_pullup.py

@@ -54,13 +54,12 @@ def pull_up_source_ids(node: nodes.ReadTableNode) -> nodes.BigFrameNode:
     if all(id.sql == source_id for id, source_id in node.scan_list.items):
         return node
     else:
-        source_ids = sorted(
-            set(scan_item.source_id for scan_item in node.scan_list.items)
-        )
         new_scan_list = nodes.ScanList.from_items(
             [
-                nodes.ScanItem(identifiers.ColumnId(source_id), source_id)
-                for source_id in source_ids
+                nodes.ScanItem(
+                    identifiers.ColumnId(scan_item.source_id), scan_item.source_id
+                )
+                for scan_item in node.scan_list.items
             ]
         )
         new_source = dataclasses.replace(node, scan_list=new_scan_list)

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_binary_compiler/test_corr/out.sql

@@ -1,7 +1,7 @@
 WITH `bfcte_0` AS (
   SELECT
-    `float64_col`,
-    `int64_col`
+    `int64_col`,
+    `float64_col`
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_binary_compiler/test_cov/out.sql

@@ -1,7 +1,7 @@
 WITH `bfcte_0` AS (
   SELECT
-    `float64_col`,
-    `int64_col`
+    `int64_col`,
+    `float64_col`
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_nullary_compiler/test_size/out.sql

@@ -4,17 +4,17 @@ WITH `bfcte_0` AS (
     `bytes_col`,
     `date_col`,
     `datetime_col`,
-    `duration_col`,
-    `float64_col`,
     `geography_col`,
     `int64_col`,
     `int64_too`,
     `numeric_col`,
+    `float64_col`,
     `rowindex`,
     `rowindex_2`,
     `string_col`,
     `time_col`,
-    `timestamp_col`
+    `timestamp_col`,
+    `duration_col`
   FROM `bigframes-dev`.`sqlglot_test`.`scalar_types`
 ), `bfcte_1` AS (
   SELECT

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_mean/out.sql

@@ -1,8 +1,8 @@
 WITH `bfcte_0` AS (
   SELECT
     `bool_col`,
-    `duration_col`,
     `int64_col`,
+    `duration_col`,
     `int64_col` AS `bfcol_6`,
     `bool_col` AS `bfcol_7`,
     `duration_col` AS `bfcol_8`

tests/unit/core/compile/sqlglot/aggregations/snapshots/test_unary_compiler/test_std/out.sql

@@ -1,8 +1,8 @@
 WITH `bfcte_0` AS (
   SELECT
     `bool_col`,
-    `duration_col`,
     `int64_col`,
+    `duration_col`,
     `int64_col` AS `bfcol_6`,
     `bool_col` AS `bfcol_7`,
     `duration_col` AS `bfcol_8`

tests/unit/core/compile/sqlglot/snapshots/test_compile_explode/test_compile_explode_dataframe/out.sql

@@ -1,7 +1,7 @@
 WITH `bfcte_0` AS (
   SELECT
-    `int_list_col`,
     `rowindex`,
+    `int_list_col`,
     `string_list_col`
   FROM `bigframes-dev`.`sqlglot_test`.`repeated_types`
 ), `bfcte_1` AS (

tests/unit/core/compile/sqlglot/snapshots/test_compile_explode/test_compile_explode_series/out.sql

@@ -1,7 +1,7 @@
 WITH `bfcte_0` AS (
   SELECT
-    `int_list_col`,
-    `rowindex`
+    `rowindex`,
+    `int_list_col`
   FROM `bigframes-dev`.`sqlglot_test`.`repeated_types`
 ), `bfcte_1` AS (
   SELECT