Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit dd39c51

Browse files
fix isin w nulls
1 parent 47a8af3 commit dd39c51

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

bigframes/core/compile/sqlglot/expressions/comparison_ops.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def _(expr: TypedExpr, op: ops.IsInOp) -> sge.Expression:
3737
must_upcast_bools = dtypes.is_numeric(expr.dtype, include_bool=False) or any(
3838
dtypes.is_numeric(dtypes.bigframes_type(type(value)), include_bool=False)
3939
for value in op.values
40+
if not _is_null(value)
4041
)
4142
for value in op.values:
4243
if _is_null(value):

bigframes/core/rewrite/identifiers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ def remap_variables(
7272
visible to the parent node.
7373
"""
7474
# step 1: defined remappings for each individual unique node
75-
# step 2: bottom up traversal to apply remappings
75+
# step 2: top down traversal to apply remappings (mappings are value-based, so bottom-up doesn't work)
7676

7777
id_def_remaps: dict[
7878
nodes.BigFrameNode, dict[identifiers.ColumnId, identifiers.ColumnId]

0 commit comments

Comments
 (0)