cleanup unneeded round op

Author: TrevorBergeron

bigframes/core/compile/ibis_compiler/scalar_op_registry.py

@@ -1029,11 +1029,6 @@ def timedelta_floor_op_impl(x: ibis_types.NumericValue):
     return ibis_api.case().when(x > 0, x.floor()).else_(x.ceil()).end()
 
 
-@scalar_op_compiler.register_unary_op(ops.timedelta_round_op)
-def timedelta_round_op_impl(x: ibis_types.NumericValue):
-    return ibis_api.case().when(x > 0, x.floor()).else_(x.ceil()).end()
-
-
 @scalar_op_compiler.register_unary_op(ops.RemoteFunctionOp, pass_op=True)
 def remote_function_op_impl(x: ibis_types.Value, op: ops.RemoteFunctionOp):
     udf_sig = op.function_def.signature

bigframes/core/compile/sqlglot/expressions/timedelta_ops.py

@@ -30,11 +30,6 @@ def _(expr: TypedExpr) -> sge.Expression:
     return sge.Floor(this=expr.expr)
 
 
-@register_unary_op(ops.timedelta_round_op)
-def _(expr: TypedExpr) -> sge.Expression:
-    return sge.Round(this=expr.expr).cast()
-
-
 @register_unary_op(ops.ToTimedeltaOp, pass_op=True)
 def _(expr: TypedExpr, op: ops.ToTimedeltaOp) -> sge.Expression:
     value = expr.expr

bigframes/core/rewrite/timedeltas.py

@@ -189,9 +189,9 @@ def _rewrite_mul_op(left: _TypedExpr, right: _TypedExpr) -> _TypedExpr:
     result = _TypedExpr.create_op_expr(ops.mul_op, left, right)
 
     if left.dtype == dtypes.TIMEDELTA_DTYPE and dtypes.is_numeric(right.dtype):
-        return _TypedExpr.create_op_expr(ops.timedelta_round_op, result)
+        return _TypedExpr.create_op_expr(ops.timedelta_floor_op, result)
     if dtypes.is_numeric(left.dtype) and right.dtype == dtypes.TIMEDELTA_DTYPE:
-        return _TypedExpr.create_op_expr(ops.timedelta_round_op, result)
+        return _TypedExpr.create_op_expr(ops.timedelta_floor_op, result)
 
     return result
 
@@ -200,15 +200,15 @@ def _rewrite_div_op(left: _TypedExpr, right: _TypedExpr) -> _TypedExpr:
     result = _TypedExpr.create_op_expr(ops.div_op, left, right)
 
     if left.dtype == dtypes.TIMEDELTA_DTYPE and dtypes.is_numeric(right.dtype):
-        return _TypedExpr.create_op_expr(ops.timedelta_round_op, result)
+        return _TypedExpr.create_op_expr(ops.timedelta_floor_op, result)
 
     return result
 
 
 def _rewrite_floordiv_op(left: _TypedExpr, right: _TypedExpr) -> _TypedExpr:
     if left.dtype == dtypes.TIMEDELTA_DTYPE and dtypes.is_numeric(right.dtype):
         return _TypedExpr.create_op_expr(
-            ops.timedelta_round_op, _TypedExpr.create_op_expr(ops.div_op, left, right)
+            ops.timedelta_floor_op, _TypedExpr.create_op_expr(ops.div_op, left, right)
         )
 
     return _TypedExpr.create_op_expr(ops.floordiv_op, left, right)

bigframes/operations/__init__.py

@@ -224,7 +224,6 @@
     date_add_op,
     date_sub_op,
     timedelta_floor_op,
-    timedelta_round_op,
     timestamp_add_op,
     timestamp_sub_op,
     ToTimedeltaOp,
@@ -309,7 +308,6 @@
     "date_add_op",
     "date_sub_op",
     "timedelta_floor_op",
-    "timedelta_round_op",
     "timestamp_add_op",
     "timestamp_sub_op",
     "ToTimedeltaOp",

bigframes/operations/timedelta_ops.py

@@ -54,25 +54,6 @@ def output_type(self, *input_types: dtypes.ExpressionType) -> dtypes.ExpressionT
 timedelta_floor_op = TimedeltaFloorOp()
 
 
-@dataclasses.dataclass(frozen=True)
-class TimedeltaRoundOp(base_ops.UnaryOp):
-    """Rounds the numeric value to the nearest integer and use it to represent a timedelta.
-
-    This operator is only meant to be used during expression tree rewrites. Do not use it anywhere else!
-    """
-
-    name: typing.ClassVar[str] = "timedelta_round"
-
-    def output_type(self, *input_types: dtypes.ExpressionType) -> dtypes.ExpressionType:
-        input_type = input_types[0]
-        if dtypes.is_numeric(input_type) or input_type == dtypes.TIMEDELTA_DTYPE:
-            return dtypes.TIMEDELTA_DTYPE
-        raise TypeError(f"unsupported type: {input_type}")
-
-
-timedelta_round_op = TimedeltaRoundOp()
-
-
 @dataclasses.dataclass(frozen=True)
 class TimestampAddOp(base_ops.BinaryOp):
     name: typing.ClassVar[str] = "timestamp_add"