add comment on sge.JSON

sycai · sycai · commit fb6c364b8ac6 · 2025-09-22T20:25:35.000Z
diff --git a/bigframes/core/compile/sqlglot/expressions/ai_ops.py b/bigframes/core/compile/sqlglot/expressions/ai_ops.py
@@ -56,6 +56,8 @@ def _(*exprs: TypedExpr, op: ops.AIGenerateBool) -> sge.Expression:
         args.append(
             sge.Kwarg(
                 this="model_params",
+                # sge.JSON requires a newer SQLGlot version than 23.6.3.
+                # PARSE_JSON won't work as the function requires a JSON literal.
                 expression=sge.JSON(this=sge.Literal.string(op.model_params)),
             )
         )

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,8 @@ def _(*exprs: TypedExpr, op: ops.AIGenerateBool) -> sge.Expression:`
`56`	`56`	`args.append(`
`57`	`57`	`sge.Kwarg(`
`58`	`58`	`this="model_params",`
	`59`	`+ # sge.JSON requires a newer SQLGlot version than 23.6.3.`
	`60`	`+ # PARSE_JSON won't work as the function requires a JSON literal.`
`59`	`61`	`expression=sge.JSON(this=sge.Literal.string(op.model_params)),`
`60`	`62`	`)`
`61`	`63`	`)`