This repository was archived by the owner on Apr 1, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 68
feat: support full round-trip persistence for multimodal reference cols #2511
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e00bb8a
feat: preserve OBJ_REF_DTYPE table schemas on save to_gbq
shuoweil 179bde3
Merge branch 'main' into shuowei-feat-persist-obj-ref
shuoweil 19cb613
Merge branch 'main' into shuowei-feat-persist-obj-ref
shuoweil a1b262f
fix: round-trip persistence for OBJ_REF_DTYPE
shuoweil 1424700
Merge branch 'main' into shuowei-feat-persist-obj-ref
shuoweil 63f65a7
fix: resolve mypy description type mismatch error
shuoweil 58a2f67
Merge branch 'main' into shuowei-feat-persist-obj-ref
shuoweil 2f67d9c
fix(dtypes): Propagate description in convert_to_schema_field for lists
shuoweil 91ce839
Merge branch 'main' into shuowei-feat-persist-obj-ref
shuoweil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC, we can changes both
convert_to_schema_fieldandconvert_schema_fieldto achieve round-trip persistence without changes in dataframe.py.Please check how
TIMEDELTA_DESCRIPTION_TAGworks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks for the tip! I've updated convert_to_schema_field and convert_schema_field to handle description tags for OBJ_REF_DTYPE and reverted the dataframe.py updates.