fix: add type hint for progress_bar_type in read_gbq function#935
fix: add type hint for progress_bar_type in read_gbq function#935haru-256 wants to merge 1 commit into
Conversation
|
@Genesis929 |
I am the maintainer (along with @Linchin) of this library. @Linchin and I decide what gets accepted or not. @Linchin asked a question about this problem on Issue #934 but they did not get a response:
Please be aware that:
In looking at the merits of this PR, it is not testable under our current infrastructure, since we don't have type hinting in our CI/CD pipeline. Why do I go on about type hinting? In looking at the error you posted:
The error message appears to be from the Here is a similar example. Here is a link to the strings that generate that style of error message: https://github.com/microsoft/pyright/blob/5ba9dcf9802382b4db529221ba353ae3edc597ad/packages/pyright-internal/src/localization/package.nls.en-us.json#L43 Mypy uses a slightly more cryptic verbiage: |
|
Sorry for the late reply, I missed this notification. Thank you |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #934