updates test suite to accommodate new timeout parameter

Author: chalmerlowe

google/cloud/bigquery/_pandas_helpers.py

@@ -954,7 +954,7 @@ def _download_table_bqstorage(
     if "@" in table.table_id:
         raise ValueError("Reading from a specific snapshot is not currently supported.")
 
-    start_time = time.time()
+    start_time = time.monotonic()
     requested_streams = determine_requested_streams(preserve_order, max_stream_count)
 
     requested_session = bigquery_storage.types.stream.ReadSession(

google/cloud/bigquery/dbapi/cursor.py

@@ -323,6 +323,8 @@ def _bqstorage_fetch(self, bqstorage_client):
             read_session=requested_session,
             # a single stream only, as DB API is not well-suited for multithreading
             max_stream_count=1,
+            retry=None,
+            timeout=None,
         )
 
         if not read_session.streams:

tests/unit/job/test_query_pandas.py

@@ -179,6 +179,8 @@ def test_to_dataframe_bqstorage_preserve_order(query, table_read_options_kwarg):
         parent="projects/test-project",
         read_session=expected_session,
         max_stream_count=1,  # Use a single stream to preserve row order.
+        retry=None,
+        timeout=None,
     )
 
 
@@ -593,6 +595,8 @@ def test_to_dataframe_bqstorage(table_read_options_kwarg):
         parent="projects/bqstorage-billing-project",
         read_session=expected_session,
         max_stream_count=0,  # Use default number of streams for best performance.
+        retry=None,
+        timeout=None,
     )
     bqstorage_client.read_rows.assert_called_once_with(stream_id)
 
@@ -644,6 +648,8 @@ def test_to_dataframe_bqstorage_no_pyarrow_compression():
         parent="projects/bqstorage-billing-project",
         read_session=expected_session,
         max_stream_count=0,
+        retry=None,
+        timeout=None,
     )
 
 

tests/unit/test_dbapi_cursor.py

@@ -480,7 +480,11 @@ def fake_ensure_bqstorage_client(bqstorage_client=None, **kwargs):
             data_format=bigquery_storage.DataFormat.ARROW,
         )
         mock_bqstorage_client.create_read_session.assert_called_once_with(
-            parent="projects/P", read_session=expected_session, max_stream_count=1
+            parent="projects/P",
+            read_session=expected_session,
+            max_stream_count=1,
+            retry=None,
+            timeout=None,
         )
 
         # Check the data returned.

tests/unit/test_table.py

@@ -6853,6 +6853,8 @@ def test_to_arrow_iterable_w_bqstorage_max_stream_count(preserve_order):
         parent=mock.ANY,
         read_session=mock.ANY,
         max_stream_count=max_stream_count if not preserve_order else 1,
+        retry=None,
+        timeout=None,
     )
 
 
@@ -6888,4 +6890,6 @@ def test_to_dataframe_iterable_w_bqstorage_max_stream_count(preserve_order):
         parent=mock.ANY,
         read_session=mock.ANY,
         max_stream_count=max_stream_count if not preserve_order else 1,
+        retry=None,
+        timeout=None,
     )