Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit 4684a72

Browse files
committed
use default backoff instance
1 parent 3eae4aa commit 4684a72

4 files changed

Lines changed: 8 additions & 16 deletions

File tree

google/cloud/bigtable/data/_async/_mutate_rows.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,10 @@ def __init__(
102102
# Entry level errors
103103
bt_exceptions._MutateRowsIncomplete,
104104
)
105-
sleep_generator = TrackedBackoffGenerator(0.01, 2, 60)
106105
self._operation = lambda: CrossSync.retry_target(
107106
self._run_attempt,
108107
self.is_retryable,
109-
sleep_generator,
108+
metric.backoff_generator,
110109
operation_timeout,
111110
exception_factory=_retry_exception_factory,
112111
)
@@ -118,7 +117,6 @@ def __init__(
118117
self.remaining_indices = list(range(len(self.mutations)))
119118
self.errors: dict[int, list[Exception]] = {}
120119
# set up metrics
121-
metric.backoff_generator = sleep_generator
122120
self._operation_metric = metric
123121

124122
@CrossSync.convert

google/cloud/bigtable/data/_async/_read_rows.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@ def start_operation(self) -> CrossSync.Iterable[Row]:
118118
Yields:
119119
Row: The next row in the stream
120120
"""
121-
self._operation_metric.backoff_generator = TrackedBackoffGenerator(
122-
0.01, 60, multiplier=2
123-
)
124121
return CrossSync.retry_target_stream(
125122
self._read_rows_attempt,
126123
self._predicate,

google/cloud/bigtable/data/_async/client.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1345,11 +1345,9 @@ async def sample_row_keys(
13451345
retryable_excs = _get_retryable_errors(retryable_errors, self)
13461346
predicate = retries.if_exception_type(*retryable_excs)
13471347

1348-
sleep_generator = TrackedBackoffGenerator(0.01, 2, 60)
1349-
13501348
async with self._metrics.create_operation(
1351-
OperationType.SAMPLE_ROW_KEYS, backoff_generator=sleep_generator
1352-
):
1349+
OperationType.SAMPLE_ROW_KEYS
1350+
) as operation_metric:
13531351

13541352
@CrossSync.convert
13551353
async def execute_rpc():
@@ -1365,7 +1363,7 @@ async def execute_rpc():
13651363
return await CrossSync.retry_target(
13661364
execute_rpc,
13671365
predicate,
1368-
sleep_generator,
1366+
operation_metric.backoff_generator,
13691367
operation_timeout,
13701368
exception_factory=_retry_exception_factory,
13711369
)
@@ -1479,10 +1477,9 @@ async def mutate_row(
14791477
# mutations should not be retried
14801478
predicate = retries.if_exception_type()
14811479

1482-
sleep_generator = TrackedBackoffGenerator(0.01, 2, 60)
14831480
async with self._metrics.create_operation(
1484-
OperationType.MUTATE_ROW, backoff_generator=sleep_generator
1485-
):
1481+
OperationType.MUTATE_ROW
1482+
) as operation_metric:
14861483
target = partial(
14871484
self.client._gapic_client.mutate_row,
14881485
request=MutateRowRequest(
@@ -1499,7 +1496,7 @@ async def mutate_row(
14991496
return await CrossSync.retry_target(
15001497
target,
15011498
predicate,
1502-
sleep_generator,
1499+
operation_metric.backoff_generator,
15031500
operation_timeout,
15041501
exception_factory=_retry_exception_factory,
15051502
)

google/cloud/bigtable/data/_metrics/data_model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,4 +429,4 @@ async def __aexit__(self, exc_type, exc_val, exc_tb):
429429
if exc_val is None:
430430
self.end_with_success()
431431
else:
432-
self.end_with_status(exc_val)
432+
self.end_with_status(exc_val)

0 commit comments

Comments
 (0)