fix: Made generate_consistency_token and check_consistency public (#1116)

methods

Author: gkevinzheng

google/cloud/bigtable/admin_v2/gapic_metadata.json

@@ -496,7 +496,7 @@
           "rpcs": {
             "CheckConsistency": {
               "methods": [
-                "_check_consistency"
+                "check_consistency"
               ]
             },
             "CopyBackup": {
@@ -551,7 +551,7 @@
             },
             "GenerateConsistencyToken": {
               "methods": [
-                "_generate_consistency_token"
+                "generate_consistency_token"
               ]
             },
             "GetAuthorizedView": {
@@ -651,7 +651,7 @@
           "rpcs": {
             "CheckConsistency": {
               "methods": [
-                "_check_consistency"
+                "check_consistency"
               ]
             },
             "CopyBackup": {
@@ -706,7 +706,7 @@
             },
             "GenerateConsistencyToken": {
               "methods": [
-                "_generate_consistency_token"
+                "generate_consistency_token"
               ]
             },
             "GetAuthorizedView": {
@@ -806,7 +806,7 @@
           "rpcs": {
             "CheckConsistency": {
               "methods": [
-                "_check_consistency"
+                "check_consistency"
               ]
             },
             "CopyBackup": {
@@ -861,7 +861,7 @@
             },
             "GenerateConsistencyToken": {
               "methods": [
-                "_generate_consistency_token"
+                "generate_consistency_token"
               ]
             },
             "GetAuthorizedView": {

google/cloud/bigtable/admin_v2/services/bigtable_table_admin/async_client.py

@@ -2123,7 +2123,7 @@ async def sample_drop_row_range():
             metadata=metadata,
         )
 
-    async def _generate_consistency_token(
+    async def generate_consistency_token(
         self,
         request: Optional[
             Union[bigtable_table_admin.GenerateConsistencyTokenRequest, dict]
@@ -2161,7 +2161,7 @@ async def sample_generate_consistency_token():
                 )
 
                 # Make the request
-                response = await client._generate_consistency_token(request=request)
+                response = await client.generate_consistency_token(request=request)
 
                 # Handle the response
                 print(response)
@@ -2243,7 +2243,7 @@ async def sample_generate_consistency_token():
         # Done; return the response.
         return response
 
-    async def _check_consistency(
+    async def check_consistency(
         self,
         request: Optional[
             Union[bigtable_table_admin.CheckConsistencyRequest, dict]
@@ -2282,7 +2282,7 @@ async def sample_check_consistency():
                 )
 
                 # Make the request
-                response = await client._check_consistency(request=request)
+                response = await client.check_consistency(request=request)
 
                 # Handle the response
                 print(response)

google/cloud/bigtable/admin_v2/services/bigtable_table_admin/client.py

@@ -2624,7 +2624,7 @@ def sample_drop_row_range():
             metadata=metadata,
         )
 
-    def _generate_consistency_token(
+    def generate_consistency_token(
         self,
         request: Optional[
             Union[bigtable_table_admin.GenerateConsistencyTokenRequest, dict]
@@ -2662,7 +2662,7 @@ def sample_generate_consistency_token():
                 )
 
                 # Make the request
-                response = client._generate_consistency_token(request=request)
+                response = client.generate_consistency_token(request=request)
 
                 # Handle the response
                 print(response)
@@ -2743,7 +2743,7 @@ def sample_generate_consistency_token():
         # Done; return the response.
         return response
 
-    def _check_consistency(
+    def check_consistency(
         self,
         request: Optional[
             Union[bigtable_table_admin.CheckConsistencyRequest, dict]
@@ -2782,7 +2782,7 @@ def sample_check_consistency():
                 )
 
                 # Make the request
-                response = client._check_consistency(request=request)
+                response = client.check_consistency(request=request)
 
                 # Handle the response
                 print(response)

google/cloud/bigtable/admin_v2/types/instance.py

@@ -759,6 +759,9 @@ class LogicalView(proto.Message):
             that the client has an up-to-date value before
             proceeding. The server returns an ABORTED error
             on a mismatched etag.
+        deletion_protection (bool):
+            Optional. Set to true to make the LogicalView
+            protected against deletion.
     """
 
     name: str = proto.Field(
@@ -773,6 +776,10 @@ class LogicalView(proto.Message):
         proto.STRING,
         number=3,
     )
+    deletion_protection: bool = proto.Field(
+        proto.BOOL,
+        number=6,
+    )
 
 
 class MaterializedView(proto.Message):

…dmin_check_consistency_async_internal.py …e_table_admin_check_consistency_async.pysamples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async.py samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async.py

@@ -23,7 +23,7 @@
 #   python3 -m pip install google-cloud-bigtable-admin
 
 
-# [START bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async_internal]
+# [START bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async]
 # This snippet has been automatically generated and should be regarded as a
 # code template only.
 # It will require modifications to work:
@@ -45,9 +45,9 @@ async def sample_check_consistency():
     )
 
     # Make the request
-    response = await client._check_consistency(request=request)
+    response = await client.check_consistency(request=request)
 
     # Handle the response
     print(response)
 
-# [END bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async_internal]
+# [END bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async]

…admin_check_consistency_sync_internal.py …le_table_admin_check_consistency_sync.pysamples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync.py samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync.py

@@ -23,7 +23,7 @@
 #   python3 -m pip install google-cloud-bigtable-admin
 
 
-# [START bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync_internal]
+# [START bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync]
 # This snippet has been automatically generated and should be regarded as a
 # code template only.
 # It will require modifications to work:
@@ -45,9 +45,9 @@ def sample_check_consistency():
     )
 
     # Make the request
-    response = client._check_consistency(request=request)
+    response = client.check_consistency(request=request)
 
     # Handle the response
     print(response)
 
-# [END bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync_internal]
+# [END bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync]

…rate_consistency_token_async_internal.py …dmin_generate_consistency_token_async.pysamples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async.py samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async.py

@@ -23,7 +23,7 @@
 #   python3 -m pip install google-cloud-bigtable-admin
 
 
-# [START bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async_internal]
+# [START bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async]
 # This snippet has been automatically generated and should be regarded as a
 # code template only.
 # It will require modifications to work:
@@ -44,9 +44,9 @@ async def sample_generate_consistency_token():
     )
 
     # Make the request
-    response = await client._generate_consistency_token(request=request)
+    response = await client.generate_consistency_token(request=request)
 
     # Handle the response
     print(response)
 
-# [END bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async_internal]
+# [END bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async]

…erate_consistency_token_sync_internal.py …admin_generate_consistency_token_sync.pysamples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync.py samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync_internal.py renamed to samples/generated_samples/bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync.py

@@ -23,7 +23,7 @@
 #   python3 -m pip install google-cloud-bigtable-admin
 
 
-# [START bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync_internal]
+# [START bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync]
 # This snippet has been automatically generated and should be regarded as a
 # code template only.
 # It will require modifications to work:
@@ -44,9 +44,9 @@ def sample_generate_consistency_token():
     )
 
     # Make the request
-    response = client._generate_consistency_token(request=request)
+    response = client.generate_consistency_token(request=request)
 
     # Handle the response
     print(response)
 
-# [END bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync_internal]
+# [END bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync]

samples/generated_samples/snippet_metadata_google.bigtable.admin.v2.json

@@ -5108,7 +5108,7 @@
           "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient",
           "shortName": "BaseBigtableTableAdminAsyncClient"
         },
-        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient._check_consistency",
+        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient.check_consistency",
         "method": {
           "fullName": "google.bigtable.admin.v2.BigtableTableAdmin.CheckConsistency",
           "service": {
@@ -5144,13 +5144,13 @@
           }
         ],
         "resultType": "google.cloud.bigtable.admin_v2.types.CheckConsistencyResponse",
-        "shortName": "_check_consistency"
+        "shortName": "check_consistency"
       },
       "description": "Sample for CheckConsistency",
-      "file": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async_internal.py",
+      "file": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async.py",
       "language": "PYTHON",
       "origin": "API_DEFINITION",
-      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async_internal",
+      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_async",
       "segments": [
         {
           "end": 52,
@@ -5183,7 +5183,7 @@
           "type": "RESPONSE_HANDLING"
         }
       ],
-      "title": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async_internal.py"
+      "title": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_async.py"
     },
     {
       "canonical": true,
@@ -5192,7 +5192,7 @@
           "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient",
           "shortName": "BaseBigtableTableAdminClient"
         },
-        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient._check_consistency",
+        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient.check_consistency",
         "method": {
           "fullName": "google.bigtable.admin.v2.BigtableTableAdmin.CheckConsistency",
           "service": {
@@ -5228,13 +5228,13 @@
           }
         ],
         "resultType": "google.cloud.bigtable.admin_v2.types.CheckConsistencyResponse",
-        "shortName": "_check_consistency"
+        "shortName": "check_consistency"
       },
       "description": "Sample for CheckConsistency",
-      "file": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync_internal.py",
+      "file": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync.py",
       "language": "PYTHON",
       "origin": "API_DEFINITION",
-      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync_internal",
+      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_CheckConsistency_sync",
       "segments": [
         {
           "end": 52,
@@ -5267,7 +5267,7 @@
           "type": "RESPONSE_HANDLING"
         }
       ],
-      "title": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync_internal.py"
+      "title": "bigtableadmin_v2_generated_bigtable_table_admin_check_consistency_sync.py"
     },
     {
       "canonical": true,
@@ -6937,7 +6937,7 @@
           "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient",
           "shortName": "BaseBigtableTableAdminAsyncClient"
         },
-        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient._generate_consistency_token",
+        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminAsyncClient.generate_consistency_token",
         "method": {
           "fullName": "google.bigtable.admin.v2.BigtableTableAdmin.GenerateConsistencyToken",
           "service": {
@@ -6969,13 +6969,13 @@
           }
         ],
         "resultType": "google.cloud.bigtable.admin_v2.types.GenerateConsistencyTokenResponse",
-        "shortName": "_generate_consistency_token"
+        "shortName": "generate_consistency_token"
       },
       "description": "Sample for GenerateConsistencyToken",
-      "file": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async_internal.py",
+      "file": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async.py",
       "language": "PYTHON",
       "origin": "API_DEFINITION",
-      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async_internal",
+      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_async",
       "segments": [
         {
           "end": 51,
@@ -7008,7 +7008,7 @@
           "type": "RESPONSE_HANDLING"
         }
       ],
-      "title": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async_internal.py"
+      "title": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_async.py"
     },
     {
       "canonical": true,
@@ -7017,7 +7017,7 @@
           "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient",
           "shortName": "BaseBigtableTableAdminClient"
         },
-        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient._generate_consistency_token",
+        "fullName": "google.cloud.bigtable.admin_v2.BaseBigtableTableAdminClient.generate_consistency_token",
         "method": {
           "fullName": "google.bigtable.admin.v2.BigtableTableAdmin.GenerateConsistencyToken",
           "service": {
@@ -7049,13 +7049,13 @@
           }
         ],
         "resultType": "google.cloud.bigtable.admin_v2.types.GenerateConsistencyTokenResponse",
-        "shortName": "_generate_consistency_token"
+        "shortName": "generate_consistency_token"
       },
       "description": "Sample for GenerateConsistencyToken",
-      "file": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync_internal.py",
+      "file": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync.py",
       "language": "PYTHON",
       "origin": "API_DEFINITION",
-      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync_internal",
+      "regionTag": "bigtableadmin_v2_generated_BigtableTableAdmin_GenerateConsistencyToken_sync",
       "segments": [
         {
           "end": 51,
@@ -7088,7 +7088,7 @@
           "type": "RESPONSE_HANDLING"
         }
       ],
-      "title": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync_internal.py"
+      "title": "bigtableadmin_v2_generated_bigtable_table_admin_generate_consistency_token_sync.py"
     },
     {
       "canonical": true,