Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit 66065e1

Browse files
committed
addressed review feedback
1 parent 24a4a1d commit 66065e1

3 files changed

Lines changed: 3 additions & 11 deletions

File tree

google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/async_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
from google.api_core import retry as retries
3636

3737
try:
38-
OptionalRetry = Union[retries.Retry, gapic_v1.method._MethodDefault, None]
38+
OptionalRetry = Union[retries.AsyncRetry, gapic_v1.method._MethodDefault, None]
3939
except AttributeError: # pragma: NO COVER
40-
OptionalRetry = Union[retries.Retry, object, None] # type: ignore
40+
OptionalRetry = Union[retries.AsyncRetry, object, None] # type: ignore
4141

4242
from google.api_core import client_options as client_options_lib
4343
from google.auth import credentials as ga_credentials # type: ignore
@@ -160,7 +160,7 @@ async def wait_for_consistency(
160160
# https://googleapis.dev/python/google-api-core/latest/client_options.html
161161
from google.cloud.bigtable import admin_v2
162162
163-
def sample_wait_for_consistency():
163+
async def sample_wait_for_consistency():
164164
# Create a client
165165
client = admin_v2.BigtableTableAdminAsyncClient()
166166

google/cloud/bigtable/admin_v2/overlay/types/async_consistency.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,6 @@ def __init__(
7272
async def done(self, retry: OptionalRetry = None):
7373
"""Polls the underlying `check_consistency` call to see if the future is complete.
7474
75-
This should not be used by the user to wait until the `check_consistency` call finishes;
76-
use the :meth:`result <google.api_core.future.async_future.AsyncFuture.result>` method of
77-
this class instead.
78-
7975
Args:
8076
retry (google.api_core.retry.Retry): (Optional) How to retry the
8177
polling RPC (to not be confused with polling configuration. See

google/cloud/bigtable/admin_v2/overlay/types/consistency.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ def __init__(
6868
def done(self, retry: OptionalRetry = None):
6969
"""Polls the underlying `check_consistency` call to see if the future is complete.
7070
71-
This should not be used by the user to wait until the `check_consistency` call finishes;
72-
use the :meth:`result <google.api_core.future.polling.PollingFuture.result>` method of
73-
this class instead.
74-
7571
Args:
7672
retry (google.api_core.retry.Retry): (Optional) How to retry the
7773
polling RPC (to not be confused with polling configuration. See

0 commit comments

Comments
 (0)