iterating on tests

Author: daniel-sanche

tests/system/data/test_system.py

@@ -595,6 +595,27 @@ async def test_check_and_mutate(
     expected_value = true_mutation_value if expected_result else false_mutation_value
     assert (await _retrieve_cell_value(table, row_key)) == expected_value
 
+@pytest.mark.skipif(
+    bool(os.environ.get(BIGTABLE_EMULATOR)),
+    reason="emulator doesn't raise InvalidArgument",
+)
+@pytest.mark.usefixtures("client")
+@pytest.mark.usefixtures("table")
+@pytest.mark.asyncio
+async def test_check_and_mutate_empty_request(client, table):
+    """
+    check_and_mutate with no true or fale mutations should raise an error
+    """
+    from google.api_core import exceptions
+
+    with pytest.raises(exceptions.InvalidArgument) as e:
+        await table.check_and_mutate_row(
+            b'row_key',
+            None,
+            true_case_mutations=None,
+            false_case_mutations=None
+        )
+    assert "No mutations provided" in str(e.value)
 
 @pytest.mark.usefixtures("table")
 @retry.AsyncRetry(predicate=retry.if_exception_type(ClientError), initial=1, maximum=5)

tests/unit/data/_async/test_client.py

@@ -58,6 +58,10 @@ def _make_one(self, *args, use_emulator=True, **kwargs):
         # emulator mode must be disabled by tests that check channel pooling/refresh background tasks
         if use_emulator:
             env_mask["BIGTABLE_EMULATOR_HOST"] = "localhost"
+        else:
+            # set some default values
+            kwargs["credentials"] = kwargs.get("credentials", AnonymousCredentials())
+            kwargs["project"] = kwargs.get("project", "project-id")
         with mock.patch.dict(os.environ, env_mask):
             return self._get_target_class()(*args, **kwargs)
 
@@ -2758,22 +2762,6 @@ async def test_check_and_mutate_bad_timeout(self):
                     )
                 assert str(e.value) == "operation_timeout must be greater than 0"
 
-    @pytest.mark.asyncio
-    async def test_check_and_mutate_no_mutations(self):
-        """Requests require either true_case_mutations or false_case_mutations"""
-        from google.api_core.exceptions import InvalidArgument
-
-        async with self._make_client() as client:
-            async with client.get_table("instance", "table") as table:
-                with pytest.raises(InvalidArgument) as e:
-                    await table.check_and_mutate_row(
-                        b"row_key",
-                        None,
-                        true_case_mutations=None,
-                        false_case_mutations=None,
-                    )
-                assert "No mutations provided" in str(e.value)
-
     @pytest.mark.asyncio
     async def test_check_and_mutate_single_mutations(self):
         """if single mutations are passed, they should be internally wrapped in a list"""