fixed bug in parsing bulk mutations errors

Author: daniel-sanche

google/cloud/bigtable/data/_metrics/data_model.py

@@ -410,8 +410,14 @@ def _exc_to_status(exc: Exception) -> StatusCode:
         Args:
           - exc: The exception to extract the status code from.
         """
-        if isinstance(exc, bt_exceptions._BigtableExceptionGroup):
+        # parse bigtable custom exceptions
+        if isinstance(exc, (bt_exceptions.MutationsExceptionGroup, bt_exceptions.ShardedReadRowsExceptionGroup)) and exc.exceptions:
+            # grab the RetryExceptionGroup from the most last failed mutation/shard
+            exc = exc.exceptions[-1].__cause__
+        if isinstance(exc, bt_exceptions.RetryExceptionGroup):
+            # grab the last exception in the retry group
             exc = exc.exceptions[-1]
+        # parse grpc exceptions
         if hasattr(exc, "grpc_status_code") and exc.grpc_status_code is not None:
             return exc.grpc_status_code
         if (

tests/system/data/test_metrics.py

@@ -134,11 +134,11 @@ def side_effect(*args, **kwargs):
     async with table_with_profile("retry_then_timeout") as table:
         stubs = {k:v for k,v in _get_stubs_for_table(table).items() if k not in non_retryable_rpcs}
         for rpc_name, stub_list in stubs.items():
-            with mock.patch("google.cloud.bigtable.data._helpers.exp_sleep_generator", side_effect=[0, 0, 5]):
                 with mock.patch(f"google.cloud.bigtable_v2.BigtableAsyncClient.{rpc_name}", side_effect=ServiceUnavailable("test")):
                     for stub in stub_list:
-                        with pytest.raises((DeadlineExceeded, MutationsExceptionGroup)):
-                            await stub(operation_timeout=0.5, retryable_errors=(ServiceUnavailable,))
+                        with mock.patch("google.cloud.bigtable.data._helpers.exponential_sleep_generator", return_value=iter([0.01, 0.01, 5])):
+                            with pytest.raises((DeadlineExceeded, MutationsExceptionGroup)):
+                                await stub(operation_timeout=0.5, retryable_errors=(ServiceUnavailable,))
 
     # Calls hit retryable errors, then hit terminal exception
     print("populating retryable then terminal error rpcs...")