Changed no mutations to raise ValueError instead of status

Author: gkevinzheng

google/cloud/bigtable/row.py

@@ -446,8 +446,7 @@ def commit(self):
         """Makes a ``MutateRow`` API request.
 
         If no mutations have been created in the row, no request is made and a
-        :class:`~google.rpc.status_pb2.Status` with code INVALID_ARGUMENT is returned
-        instead.
+        ValueError is raised instead.
 
         Mutations are applied atomically and in order, meaning that earlier
         mutations can be masked / negated by later ones. Cells already present
@@ -466,6 +465,7 @@ def commit(self):
         :rtype: :class:`~google.rpc.status_pb2.Status`
         :returns: A response status (`google.rpc.status_pb2.Status`)
                   representing success or failure of the row committed.
+        :raises: ValueError: if no mutations have been created in the row
         """
         try:
             self._table._table_impl.mutate_row(self.row_key, self._get_mutations())
@@ -479,12 +479,8 @@ def commit(self):
                 message=e.message,
                 details=e.details,
             )
-        except ValueError as e:
-            # _table_impl.mutate_row raises a ValueError if invalid arguments are provided.
-            return status_pb2.Status(
-                code=code_pb2.INVALID_ARGUMENT,
-                message=str(e),
-            )
+        except ValueError:
+            raise
         finally:
             self.clear()
 

tests/system/v2_client/test_data_api.py

@@ -1092,10 +1092,10 @@ def test_table_direct_row_input_errors(data_table, rows_to_delete):
     resp = row.commit()
     assert resp.code == StatusCode.INVALID_ARGUMENT.value[0]
 
-    # Not having any mutations gives an INVALID_ARGUMENT
+    # Not having any mutations raises a ValueError
     row.clear()
-    resp = row.commit()
-    assert resp.code == StatusCode.INVALID_ARGUMENT.value[0]
+    with pytest.raises(ValueError):
+        resp = row.commit()
 
 
 def test_table_conditional_row_input_errors(data_table, rows_to_delete):

tests/unit/v2_client/test_row.py

@@ -494,11 +494,8 @@ def test_direct_row_commit_with_invalid_argument():
     client._table_data_client._gapic_client = api
 
     # Perform the method and check the result.
-    result = row.commit()
-    assert row._mutations == []
-    assert result == status_pb2.Status(
-        code=code_pb2.Code.INVALID_ARGUMENT, message="No mutations provided"
-    )
+    with pytest.raises(ValueError, match="No mutations provided"):
+        row.commit()
     api.mutate_row.assert_not_called()