Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit 9b3fb6c

Browse files
committed
test: Use latest conformance test version and exclude unsupported features
1 parent 7a91bbf commit 9b3fb6c

2 files changed

Lines changed: 11 additions & 10 deletions

File tree

.github/workflows/conformance.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,20 @@ jobs:
2424
runs-on: ubuntu-latest
2525
strategy:
2626
matrix:
27-
test-version: [ "v0.0.2" ]
27+
test-version: [ "v0.0.4" ]
2828
py-version: [ 3.8 ]
2929
client-type: [ "async", "sync", "legacy" ]
30+
# None of the clients currently support reverse scans, execute query plan refresh, retry info, or routing cookie
3031
include:
32+
- client-type: "async"
33+
test_args: "-skip \"PlanRefresh|_Reverse|_WithRetryInfo|_WithRoutingCookie\""
3134
- client-type: "sync"
32-
# sync client does not support concurrent streams
33-
test_args: "-skip _Generic_MultiStream"
35+
test_args: "-skip \"PlanRefresh|_Reverse|_WithRetryInfo|_WithRoutingCookie|_Generic_MultiStream\""
3436
- client-type: "legacy"
3537
# legacy client is synchronous and does not support concurrent streams
3638
# legacy client does not expose mutate_row. Disable those tests
37-
test_args: "-skip _Generic_MultiStream -skip TestMutateRow_"
39+
# legacy client does not support execute_query
40+
test_args: "-skip \"_Generic_MultiStream|TestExecuteQuery_|_Reverse|_WithRetryInfo|_WithRoutingCookie\""
3841
fail-fast: false
3942
name: "${{ matrix.client-type }} client / python ${{ matrix.py-version }} / test tag ${{ matrix.test-version }}"
4043
steps:

test_proxy/handlers/grpc_handler.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,10 @@ def BulkMutateRows(self, request, context, client_response=None):
116116
)
117117
for exc_dict in client_response.get("subexceptions", [])
118118
]
119-
if not entries:
120-
# only return failure on the overall request if there are failed entries
121-
status = Status(
122-
code=client_response.get("code", 5),
123-
message=client_response["error"],
124-
)
119+
status = Status(
120+
code=client_response.get("code", 5),
121+
message=client_response["error"],
122+
)
125123
response = test_proxy_pb2.MutateRowsResult(status=status, entries=entries)
126124
return response
127125

0 commit comments

Comments
 (0)