fixed lint

Author: daniel-sanche

google/cloud/bigtable/data/_metrics/data_model.py

@@ -65,20 +65,20 @@ class OperationType(Enum):
 class OperationState(Enum):
     """Enum for the state of the active operation.
 
-       ┌───────────┐
-       │  CREATED  │
-       └─────┬─────┘
-             │
-             ▼
-      ┌▶ ACTIVE_ATTEMPT ───┐
-      │      │             │
-      │      ▼             │
-      └─ BETWEEN_ATTEMPTS  │
-             │             │
-             ▼             ▼
-       ┌───────────┐       │
-       │ COMPLETED │ ◀─────┘
-       └───────────┘
+     ┌───────────┐
+     │  CREATED  │
+     └─────┬─────┘
+           │
+           ▼
+    ┌▶ ACTIVE_ATTEMPT ───┐
+    │      │             │
+    │      ▼             │
+    └─ BETWEEN_ATTEMPTS  │
+           │             │
+           ▼             ▼
+     ┌───────────┐       │
+     │ COMPLETED │ ◀─────┘
+     └───────────┘
     """
 
     CREATED = 0
@@ -329,7 +329,9 @@ def end_attempt_with_status(self, status: StatusCode | BaseException) -> None:
             )
         if isinstance(status, BaseException):
             status = self._exc_to_status(status)
-        duration_ns = self._ensure_positive(time.monotonic_ns() - self.active_attempt.start_time_ns, "duration")
+        duration_ns = self._ensure_positive(
+            time.monotonic_ns() - self.active_attempt.start_time_ns, "duration"
+        )
         complete_attempt = CompletedAttemptMetric(
             duration_ns=duration_ns,
             end_status=status,
@@ -365,7 +367,9 @@ def end_with_status(self, status: StatusCode | BaseException) -> None:
         )
         if self.state == OperationState.ACTIVE_ATTEMPT:
             self.end_attempt_with_status(final_status)
-        duration_ns = self._ensure_positive(time.monotonic_ns() - self.start_time_ns, "duration")
+        duration_ns = self._ensure_positive(
+            time.monotonic_ns() - self.start_time_ns, "duration"
+        )
         finalized = CompletedOperationMetric(
             op_type=self.op_type,
             completed_attempts=self.completed_attempts,
@@ -430,7 +434,7 @@ def _handle_error(message: str) -> None:
         full_message = f"Error in Bigtable Metrics: {message}"
         LOGGER.warning(full_message)
 
-    def _ensure_positive(self, value:int, field_name:str) -> int:
+    def _ensure_positive(self, value: int, field_name: str) -> int:
         """
         Helper to replace negative value with 0, and record an error
         """

tests/unit/data/_metrics/test_data_model.py

@@ -271,7 +271,10 @@ def test_add_response_metadata_cbt_header(
         cls = type(self._make_one(mock.Mock()))
         with mock.patch.object(cls, "_handle_error") as mock_handle_error:
             metric = self._make_one(
-                mock.Mock(), cluster_id=start_cluster, zone=start_zone, state=State.ACTIVE_ATTEMPT
+                mock.Mock(),
+                cluster_id=start_cluster,
+                zone=start_zone,
+                state=State.ACTIVE_ATTEMPT,
             )
             metric.active_attempt = mock.Mock()
             metric.active_attempt.gfe_latency_ns = None
@@ -391,7 +394,6 @@ def test_end_attempt_with_status(self, mock_monotonic_ns):
         expected_gfe_latency_ns = 5
         expected_app_blocking = 12
         expected_backoff = 2
-        expected_grpc_throttle = 3
         handlers = [mock.Mock(), mock.Mock()]
 
         metric = self._make_one(mock.Mock(), handlers=handlers)
@@ -450,7 +452,10 @@ def test_end_attempt_with_negative_duration_ns(self, mock_monotonic_ns):
             metric.end_attempt_with_status(mock.Mock())
 
             assert mock_handle_error.call_count == 1
-            assert "received negative value for duration" in mock_handle_error.call_args[0][0]
+            assert (
+                "received negative value for duration"
+                in mock_handle_error.call_args[0][0]
+            )
             assert metric.completed_attempts[0].duration_ns == 0
 
     @mock.patch("time.monotonic_ns")
@@ -479,7 +484,10 @@ def test_end_with_status(self, mock_monotonic_ns):
 
         handlers = [mock.Mock(), mock.Mock()]
         metric = self._make_one(
-            expected_type, handlers=handlers, start_time_ns=expected_start_time, state=State.ACTIVE_ATTEMPT
+            expected_type,
+            handlers=handlers,
+            start_time_ns=expected_start_time,
+            state=State.ACTIVE_ATTEMPT,
         )
         metric.cluster_id = expected_cluster
         metric.zone = expected_zone
@@ -534,7 +542,10 @@ def test_end_with_negative_duration_ns(self, mock_monotonic_ns):
             metric.end_with_status(mock.Mock())
 
             assert mock_handle_error.call_count == 1
-            assert "received negative value for duration" in mock_handle_error.call_args[0][0]
+            assert (
+                "received negative value for duration"
+                in mock_handle_error.call_args[0][0]
+            )
             final_op = metric.handlers[0].on_operation_complete.call_args[0][0]
             assert final_op.duration_ns == 0