Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Commit bf7dc8d

Browse files
committed
fix kokoro configs
1 parent 150ec60 commit bf7dc8d

4 files changed

Lines changed: 26 additions & 21 deletions

File tree

.kokoro/presubmit/common.cfg

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ action {
77
}
88
}
99

10+
# TODO: remove after deprecating 3.7 and 3.8
11+
env_vars: {
12+
key: "NOX_SESSION"
13+
value: "unit-3.9 unit-3.10 unit-3.11 unit-3.12 unit-3.13 unit-3.14 docs lint lint_setup_py blacken cover"
14+
}
15+
1016
# Download trampoline resources.
1117
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/trampoline"
1218

.kokoro/presubmit/system.cfg

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# Format: //devtools/kokoro/config/proto/build.proto
2+
3+
# Only run this nox session.
4+
env_vars: {
5+
key: "NOX_SESSION"
6+
value: "system-3.9"
7+
}

mypy.ini

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
[mypy]
2-
python_version = 3.8
2+
python_version = 3.9
33
namespace_packages = True
4+
check_untyped_defs = True
5+
warn_unreachable = True
6+
disallow_any_generics = True
47
exclude = tests/unit/gapic/
58

69
[mypy-grpc.*]
@@ -26,3 +29,10 @@ ignore_missing_imports = True
2629

2730
[mypy-pytest]
2831
ignore_missing_imports = True
32+
33+
[mypy-google.cloud.*]
34+
ignore_errors = True
35+
36+
# only verify data client
37+
[mypy-google.cloud.bigtable.data.*]
38+
ignore_errors = False

noxfile.py

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
ISORT_VERSION = "isort==5.11.0"
3333
LINT_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]
3434

35-
DEFAULT_PYTHON_VERSION = "3.8"
35+
DEFAULT_PYTHON_VERSION = "3.9"
3636

3737
UNIT_TEST_PYTHON_VERSIONS: List[str] = [
3838
"3.7",
@@ -149,20 +149,7 @@ def mypy(session):
149149
"mypy", "types-setuptools", "types-protobuf", "types-mock", "types-requests"
150150
)
151151
session.install("google-cloud-testutils")
152-
session.run(
153-
"mypy",
154-
"-p",
155-
"google.cloud.bigtable.data",
156-
"--check-untyped-defs",
157-
"--warn-unreachable",
158-
"--disallow-any-generics",
159-
"--exclude",
160-
"tests/system/v2_client",
161-
"--exclude",
162-
"tests/unit/v2_client",
163-
"--disable-error-code",
164-
"func-returns-value", # needed for CrossSync.rm_aio
165-
)
152+
session.run("mypy", "-p", "google.cloud.bigtable.data")
166153

167154

168155
@nox.session(python=DEFAULT_PYTHON_VERSION)
@@ -211,11 +198,6 @@ def unit(session, protobuf_implementation):
211198
if protobuf_implementation == "cpp" and py_version >= (3, 11):
212199
session.skip("cpp implementation is not supported in python 3.11+")
213200

214-
# Skip python 3.7 and 3.8 tests if not available in kokoro environment
215-
# TODO: remove when 3.7 and 3.8 are dropped
216-
if py_version < (3, 9) and os.getenv("KOKORO_BUILD_ID"):
217-
session.skip("skipping deprecated python versions")
218-
219201
constraints_path = str(
220202
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
221203
)

0 commit comments

Comments
 (0)