linting

Author: gkevinzheng

tests/unit/admin_overlay/test_client.py

@@ -16,7 +16,6 @@
 # try/except added for compatibility with python < 3.8
 try:
     from unittest import mock
-    from unittest.mock import AsyncMock  # pragma: NO COVER
 except ImportError:  # pragma: NO COVER
     import mock
 
@@ -150,11 +149,11 @@ def test_bigtable_table_admin_client_wait_for_consistency(kwargs):
 
     future = client.wait_for_consistency(**kwargs)
 
-    assert type(future) == consistency.CheckConsistencyPollingFuture
+    assert isinstance(future, consistency.CheckConsistencyPollingFuture)
     assert future._default_retry == kwargs.get("retry", gapic_v1.method.DEFAULT)
 
     check_consistency_call = future._check_consistency_call
-    assert type(check_consistency_call) == functools.partial
+    assert isinstance(check_consistency_call, functools.partial)
 
     assert check_consistency_call.func == client.check_consistency
     assert check_consistency_call.args == (kwargs.get("request", None),)
@@ -208,11 +207,11 @@ def test_bigtable_table_admin_client_wait_for_replication(kwargs):
             )
         )
 
-        assert type(future) == consistency.CheckConsistencyPollingFuture
+        assert isinstance(future, consistency.CheckConsistencyPollingFuture)
         assert future._default_retry == kwargs.get("retry", gapic_v1.method.DEFAULT)
 
         check_consistency_call = future._check_consistency_call
-        assert type(check_consistency_call) == functools.partial
+        assert isinstance(check_consistency_call, functools.partial)
 
         assert check_consistency_call.func == client.check_consistency
         assert check_consistency_call.args == (expected_check_consistency_request,)

tests/unit/admin_overlay/test_consistency.py

@@ -16,7 +16,6 @@
 # try/except added for compatibility with python < 3.8
 try:
     from unittest import mock
-    from unittest.mock import AsyncMock  # pragma: NO COVER
 except ImportError:  # pragma: NO COVER
     import mock
 
@@ -61,15 +60,15 @@ def test_check_consistency_future_result():
     future = consistency.CheckConsistencyPollingFuture(check_consistency_call)
     is_consistent = future.result()
 
-    assert is_consistent == True
+    assert is_consistent
     check_consistency_call.assert_has_calls(
         [mock.call(retry=future._default_retry)] * times
     )
 
     # Check that calling result again doesn't produce more calls.
     is_consistent = future.result()
 
-    assert is_consistent == True
+    assert is_consistent
     check_consistency_call.assert_has_calls(
         [mock.call(retry=future._default_retry)] * times
     )
@@ -84,7 +83,7 @@ def test_check_consistency_future_result_default_retry():
     )
     is_consistent = future.result()
 
-    assert is_consistent == True
+    assert is_consistent
     check_consistency_call.assert_has_calls([mock.call(retry=retry)] * times)
 
 

tests/unit/admin_overlay/test_restore_table.py

@@ -15,7 +15,6 @@
 # try/except added for compatibility with python < 3.8
 try:
     from unittest import mock
-    from unittest.mock import AsyncMock  # pragma: NO COVER
 except ImportError:  # pragma: NO COVER
     import mock
 
@@ -135,7 +134,7 @@ def test_restore_table_operation_client_success_has_optimize():
         restore_table_operation.optimize_restored_table_operation()
     )
 
-    assert type(optimize_restored_table_operation) == operation.Operation
+    assert isinstance(optimize_restored_table_operation, operation.Operation)
     assert (
         optimize_restored_table_operation._operation
         == OPTIMIZE_RESTORED_TABLE_OPERATION_PROTO
@@ -170,7 +169,7 @@ def test_restore_table_operation_success_has_optimize_also_call_result():
         restore_table_operation.optimize_restored_table_operation()
     )
 
-    assert type(optimize_restored_table_operation) == operation.Operation
+    assert isinstance(optimize_restored_table_operation, operation.Operation)
     assert (
         optimize_restored_table_operation._operation
         == OPTIMIZE_RESTORED_TABLE_OPERATION_PROTO