removed export interval option

Author: daniel-sanche

google/cloud/bigtable/data/_metrics/handlers/gcp_exporter.py

@@ -81,6 +81,9 @@
     for n in INSTRUMENT_NAMES
 ]
 
+# We use the minimum value supported by the Cloud Monitoring API (60 seconds)
+EXPORT_INTERVAL_MS = 60_000
+
 
 class GoogleCloudMetricsHandler(OpenTelemetryMetricsHandler):
     """
@@ -102,12 +105,12 @@ class GoogleCloudMetricsHandler(OpenTelemetryMetricsHandler):
       - export_interval: The interval (in seconds) at which to export metrics to Cloud Monitoring.
     """
 
-    def __init__(self, *args, project_id: str, export_interval=60, **kwargs):
+    def __init__(self, *args, project_id: str, **kwargs):
         # internal exporter to write metrics to Cloud Monitoring
         exporter = _BigtableMetricsExporter(project_id=project_id)
         # periodically executes exporter
         gcp_reader = PeriodicExportingMetricReader(
-            exporter, export_interval_millis=export_interval * 1000
+            exporter, export_interval_millis=EXPORT_INTERVAL_MS
         )
         # use private meter provider to store instruments and views
         meter_provider = MeterProvider(metric_readers=[gcp_reader], views=VIEW_LIST)

tests/unit/data/_metrics/handlers/test_handler_gcp_exporter.py

@@ -100,28 +100,6 @@ def test_uses_custom_meter_provider(self, mock_meter_provider, mock_instruments)
         assert isinstance(found_reader._exporter, _BigtableMetricsExporter)
         assert found_reader._exporter.project_name == f"projects/{project_id}"
 
-    @mock.patch(
-        "google.cloud.bigtable.data._metrics.handlers.gcp_exporter.PeriodicExportingMetricReader",
-        autospec=True,
-    )
-    def test_custom_export_interval(self, mock_reader):
-        """
-        should be able to set a custom export interval
-        """
-        input_interval = 123
-        try:
-            self._make_one(
-                export_interval=input_interval,
-                project_id="p",
-                instance_id="i",
-                table_id="t",
-            )
-        except Exception:
-            pass
-        reader_init_kwargs = mock_reader.call_args[1]
-        found_interval = reader_init_kwargs["export_interval_millis"]
-        assert found_interval == input_interval * 1000  # convert to ms
-
 
 class Test_BigtableMetricsExporter:
     def _get_class(self):