removed cancel from spec

Author: daniel-sanche

google/cloud/bigtable/data/_async/mutations_batcher.py

@@ -195,7 +195,6 @@ async def add_to_flow_with_metrics(
             try:
                 value = await inner_generator.__anext__()
             except CrossSync.StopIteration:
-                metric.cancel()
                 return
             metric.flow_throttling_time_ns = time.monotonic_ns() - flow_start_time
             yield value, metric

google/cloud/bigtable/data/_metrics/data_model.py

@@ -368,13 +368,6 @@ def end_with_success(self):
         """
         return self.end_with_status(StatusCode.OK)
 
-    def cancel(self):
-        """
-        Called to cancel an operation without processing emitting it.
-        """
-        for handler in self.handlers:
-            handler.on_operation_cancelled(self)
-
     @staticmethod
     def _exc_to_status(exc: BaseException) -> StatusCode:
         """

google/cloud/bigtable/data/_metrics/handlers/_base.py

@@ -29,9 +29,6 @@ def __init__(self, **kwargs):
     def on_operation_complete(self, op: CompletedOperationMetric) -> None:
         pass
 
-    def on_operation_cancelled(self, op: ActiveOperationMetric) -> None:
-        pass
-
     def on_attempt_complete(
         self, attempt: CompletedAttemptMetric, op: ActiveOperationMetric
     ) -> None:

tests/unit/data/_metrics/test_data_model.py

@@ -545,17 +545,6 @@ def test_interceptor_metadata(self):
         assert key == OPERATION_INTERCEPTOR_METADATA_KEY
         assert value == metric.uuid
 
-    def test_cancel(self):
-        """
-        cancel should call on_operation_cancelled on handlers
-        """
-        handlers = [mock.Mock(), mock.Mock()]
-        metric = self._make_one(mock.Mock(), handlers=handlers)
-        metric.cancel()
-        for h in handlers:
-            assert h.on_operation_cancelled.call_count == 1
-            assert h.on_operation_cancelled.call_args[0][0] == metric
-
     def test_end_with_status_with_default_cluster_zone(self):
         """
         ending the operation should use default cluster and zone if not set