linting

Author: gkevinzheng

google/cloud/bigtable/admin_v2/overlay/services/bigtable_table_admin/client.py

@@ -228,7 +228,6 @@ def sample_restore_table():
         )
         return restore_table_operation
 
-
     def wait_for_consistency(
         self,
         request: Optional[
@@ -318,11 +317,12 @@ def sample_wait_for_consistency():
             # request, apply these.
             if name is not None:
                 request.name = name
-        
 
         # Generate the consistency token.
-        generate_consistency_token_request = bigtable_table_admin.GenerateConsistencyTokenRequest(
-            name=request.name,
+        generate_consistency_token_request = (
+            bigtable_table_admin.GenerateConsistencyTokenRequest(
+                name=request.name,
+            )
         )
 
         generate_consistency_response = self.generate_consistency_token(
@@ -335,24 +335,30 @@ def sample_wait_for_consistency():
         # Create the CheckConsistencyRequest object.
         check_consistency_request = bigtable_table_admin.CheckConsistencyRequest(
             name=request.name,
-            consistency_token=generate_consistency_response.consistency_token
+            consistency_token=generate_consistency_response.consistency_token,
         )
 
         # Since the default values of StandardReadRemoteWrites and DataBoostReadLocalWrites evaluate to
         # False in proto plus, we cannot do a simple "if request.standard_read_remote_writes" to check
-        # whether or not that field is defined in the original request object. 
+        # whether or not that field is defined in the original request object.
         mode_oneof_field = request._pb.WhichOneof("mode")
         if mode_oneof_field:
-            setattr(check_consistency_request, mode_oneof_field, getattr(request, mode_oneof_field))
-    
+            setattr(
+                check_consistency_request,
+                mode_oneof_field,
+                getattr(request, mode_oneof_field),
+            )
+
         check_consistency_call = functools.partial(
             self.check_consistency,
             check_consistency_request,
             retry=retry,
             timeout=timeout,
-            metadata=metadata
+            metadata=metadata,
         )
 
         # Block and wait until the polling harness returns True.
-        check_consistency_future = consistency._CheckConsistencyPollingFuture(check_consistency_call)
+        check_consistency_future = consistency._CheckConsistencyPollingFuture(
+            check_consistency_call
+        )
         return check_consistency_future.result()

google/cloud/bigtable/admin_v2/overlay/types/wait_for_consistency_request.py

@@ -22,9 +22,10 @@
     package="google.bigtable.admin.v2",
     manifest={
         "WaitForConsistencyRequest",
-    }
+    },
 )
 
+
 # The WaitForConsistencyRequest object is not a real proto. It is a wrapper
 # class intended for the handwritten method wait_for_consistency. It is
 # constructed by extending a Proto Plus message class to get a developer
@@ -35,7 +36,7 @@ class WaitForConsistencyRequest(proto.Message):
     """Wrapper class for encapsulating parameters for the `wait_for_consistency` method in both
     :class:`google.cloud.bigtable.admin_v2.overlay.services.bigtable_table_admin.client.BigtableTableAdminClient`
     and :class:`google.cloud.bigtable.admin_v2.overlay.services.bigtable_table_admin.async_client.BigtableTableAdmiAsyncClient`.
-    
+
 
     This message has `oneof`_ fields (mutually exclusive fields).
     For each oneof, at most one member field can be set at the same time.
@@ -64,19 +65,21 @@ class WaitForConsistencyRequest(proto.Message):
 
             This field is a member of `oneof`_ ``mode``.
     """
-    name : str = proto.Field(
-        proto.STRING,
-        number=1
-    )
-    standard_read_remote_writes: bigtable_table_admin.StandardReadRemoteWrites = proto.Field(
-        proto.MESSAGE,
-        number=2,
-        oneof="mode",
-        message=bigtable_table_admin.StandardReadRemoteWrites,
+
+    name: str = proto.Field(proto.STRING, number=1)
+    standard_read_remote_writes: bigtable_table_admin.StandardReadRemoteWrites = (
+        proto.Field(
+            proto.MESSAGE,
+            number=2,
+            oneof="mode",
+            message=bigtable_table_admin.StandardReadRemoteWrites,
+        )
     )
-    data_boost_read_local_writes: bigtable_table_admin.DataBoostReadLocalWrites = proto.Field(
-        proto.MESSAGE,
-        number=3,
-        oneof="mode",
-        message=bigtable_table_admin.DataBoostReadLocalWrites,
+    data_boost_read_local_writes: bigtable_table_admin.DataBoostReadLocalWrites = (
+        proto.Field(
+            proto.MESSAGE,
+            number=3,
+            oneof="mode",
+            message=bigtable_table_admin.DataBoostReadLocalWrites,
+        )
     )

tests/unit/admin_overlay/test_client.py

@@ -30,7 +30,10 @@
     BigtableTableAdminClient,
     DEFAULT_CLIENT_INFO,
 )
-from google.cloud.bigtable.admin_v2.overlay.types import restore_table, wait_for_consistency_request
+from google.cloud.bigtable.admin_v2.overlay.types import (
+    restore_table,
+    wait_for_consistency_request,
+)
 
 from google.cloud.bigtable import __version__ as bigtable_version
 
@@ -186,7 +189,9 @@ def test_bigtable_table_admin_client_restore_table(kwargs):
         ),
     ],
 )
-def test_bigtable_table_admin_client_wait_for_consistency(kwargs, check_consistency_request_extras):
+def test_bigtable_table_admin_client_wait_for_consistency(
+    kwargs, check_consistency_request_extras
+):
     client = BigtableTableAdminClient()
     poll_count = 3
     check_mock_side_effect = [FALSE_CONSISTENCY_RESPONSE] * (poll_count - 1)
@@ -214,17 +219,19 @@ def test_bigtable_table_admin_client_wait_for_consistency(kwargs, check_consiste
                 metadata=kwargs.get("metadata", ()),
             )
 
-            expected_check_consistency_request = bigtable_table_admin.CheckConsistencyRequest(
-                name=TABLE_NAME,
-                consistency_token=CONSISTENCY_TOKEN,
-                **check_consistency_request_extras,
+            expected_check_consistency_request = (
+                bigtable_table_admin.CheckConsistencyRequest(
+                    name=TABLE_NAME,
+                    consistency_token=CONSISTENCY_TOKEN,
+                    **check_consistency_request_extras,
+                )
             )
 
             check_mock.assert_called_with(
-                    expected_check_consistency_request,
-                    retry=kwargs.get("retry", gapic_v1.method.DEFAULT),
-                    timeout=kwargs.get("timeout", gapic_v1.method.DEFAULT),
-                    metadata=kwargs.get("metadata", ()),
+                expected_check_consistency_request,
+                retry=kwargs.get("retry", gapic_v1.method.DEFAULT),
+                timeout=kwargs.get("timeout", gapic_v1.method.DEFAULT),
+                metadata=kwargs.get("metadata", ()),
             )
 
 
@@ -236,9 +243,10 @@ def test_bigtable_table_admin_client_wait_for_consistency_error_in_call():
 
     with pytest.raises(exceptions.GoogleAPICallError):
         with mock.patch.object(client, "generate_consistency_token") as generate_mock:
-            generate_mock.side_effect = exceptions.DeadlineExceeded("Deadline Exceeded.")
+            generate_mock.side_effect = exceptions.DeadlineExceeded(
+                "Deadline Exceeded."
+            )
             client.wait_for_consistency(request)
-    
 
     with pytest.raises(exceptions.GoogleAPICallError):
         with mock.patch.object(client, "generate_consistency_token") as generate_mock:
@@ -249,14 +257,18 @@ def test_bigtable_table_admin_client_wait_for_consistency_error_in_call():
                     )
                 )
 
-                check_mock.side_effect = exceptions.DeadlineExceeded("Deadline Exceeded.")
+                check_mock.side_effect = exceptions.DeadlineExceeded(
+                    "Deadline Exceeded."
+                )
                 client.wait_for_consistency(request)
 
 
 def test_bigtable_table_admin_client_wait_for_consistency_user_error():
     client = BigtableTableAdminClient()
     with pytest.raises(ValueError):
-        client.wait_for_consistency({
-            "name": TABLE_NAME,
-        },
-        name=TABLE_NAME)
+        client.wait_for_consistency(
+            {
+                "name": TABLE_NAME,
+            },
+            name=TABLE_NAME,
+        )

tests/unit/admin_overlay/test_consistency.py

@@ -61,14 +61,10 @@ def test_check_consistency_future_result():
     is_consistent = future.result()
 
     assert is_consistent
-    check_consistency_call.assert_has_calls(
-        [mock.call()] * times
-    )
+    check_consistency_call.assert_has_calls([mock.call()] * times)
 
     # Check that calling result again doesn't produce more calls.
     is_consistent = future.result()
 
     assert is_consistent
-    check_consistency_call.assert_has_calls(
-        [mock.call()] * times
-    )
+    check_consistency_call.assert_has_calls([mock.call()] * times)