This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: added confidence score and detected languages to Page classes#387
Closed
Shifat7 wants to merge 7 commits intogoogleapis:mainfrom
Closed
feat: added confidence score and detected languages to Page classes#387Shifat7 wants to merge 7 commits intogoogleapis:mainfrom
Page classes#387Shifat7 wants to merge 7 commits intogoogleapis:mainfrom
Conversation
Shifat7
requested review from
a team and
briandorsey
and removed request for
a team
product-auto-label
bot
added
size: m
Shifat7
changed the title
Shifat7
changed the title
holtskinner
suggested changes
Apr 29, 2025
Author
|
hi @holtskinner, I've moved it to the _BasePageElement, thanks for your prompt review! |
holtskinner
reviewed
Apr 29, 2025
holtskinner
reviewed
Apr 29, 2025
Author
|
hi @holtskinner , Ive removed the test samples as reviewed and other changes as well. Let me know if there's anything else |
holtskinner
suggested changes
Apr 30, 2025
Author
|
hi @holtskinner , all done thanks for reviewing! |
holtskinner
previously approved these changes
May 5, 2025
holtskinner
changed the title
Page classes
Contributor
|
Closing this PR. The alternative presented in googleapis/google-cloud-python#15817 (comment) should be sufficient for this use case. |
auto-merge was automatically disabled
January 14, 2026 16:12
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
confidenceproperty to represent the confidence score of Token detection.detected_languagesproperty to provide a list of detected languages for each Token.Fixes googleapis/google-cloud-python#15817 @sarath-mec 🦕