fixed cover

Author: daniel-sanche

tests/unit/v1/test_aggregation.py

@@ -49,6 +49,12 @@ def test_count_aggregation_to_pb():
     assert count_aggregation._to_protobuf() == expected_aggregation_query_pb
 
 
+def test_count_aggregation_no_alias_to_pb():
+    count_aggregation = CountAggregation(alias=None)
+    got_pb = count_aggregation._to_protobuf()
+    assert got_pb.alias == ""
+
+
 def test_sum_aggregation_w_field_path():
     """
     SumAggregation should convert FieldPath inputs into strings
@@ -86,6 +92,12 @@ def test_sum_aggregation_to_pb():
     assert sum_aggregation._to_protobuf() == expected_aggregation_query_pb
 
 
+def test_sum_aggregation_no_alias_to_pb():
+    sum_aggregation = SumAggregation("someref", alias=None)
+    got_pb = sum_aggregation._to_protobuf()
+    assert got_pb.alias == ""
+
+
 def test_avg_aggregation_to_pb():
     from google.cloud.firestore_v1.types import query as query_pb2
 
@@ -101,6 +113,14 @@ def test_avg_aggregation_to_pb():
     assert avg_aggregation._to_protobuf() == expected_aggregation_query_pb
 
 
+def test_avg_aggregation_no_alias_to_pb():
+    from google.cloud.firestore_v1.types import query as query_pb2
+
+    avg_aggregation = AvgAggregation("someref", alias=None)
+    got_pb = avg_aggregation._to_protobuf()
+    assert got_pb.alias == ""
+
+
 def test_aggregation_query_constructor():
     client = make_client()
     parent = client.collection("dee")

tests/unit/v1/test_watch.py

@@ -322,6 +322,17 @@ def test_watch_close():
     assert inst._closed
 
 
+def test_watch_double_close():
+    """
+    Calling close twice should succeed with no error
+    """
+    inst = _make_watch()
+    inst.close()
+    inst.close()
+    assert inst._consumer is None
+    assert inst._rpc is None
+
+
 def test_watch__get_rpc_request_wo_resume_token():
     inst = _make_watch()