fix(interactions): use NOT_GIVEN instead of None for default timeout#2464
Open
copybara-service[bot] wants to merge 1 commit into
Open
fix(interactions): use NOT_GIVEN instead of None for default timeout#2464copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When http_opts.timeout is not set by the user, the google.genai wrapper was passing timeout=None to the Stainless client. In httpx, None means 'no timeout' (wait forever). The Stainless SyncAPIClient.__init__ only falls back to DEFAULT_TIMEOUT (60s) when the value is NotGiven, not None. This caused all interactions requests to have no timeout at all, hanging indefinitely on unresponsive servers instead of raising APITimeoutError after 60 seconds. PiperOrigin-RevId: 916923417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(interactions): use NOT_GIVEN instead of None for default timeout
When http_opts.timeout is not set by the user, the google.genai wrapper
was passing timeout=None to the Stainless client. In httpx, None means
'no timeout' (wait forever). The Stainless SyncAPIClient.init only
falls back to DEFAULT_TIMEOUT (60s) when the value is NotGiven, not
None. This caused all interactions requests to have no timeout at all,
hanging indefinitely on unresponsive servers instead of raising
APITimeoutError after 60 seconds.