Skip to content
This repository was archived by the owner on Feb 26, 2026. It is now read-only.

Commit e96df9f

Browse files
committed
Fixed noxfile version + samples test sink cleanup
1 parent bf38343 commit e96df9f

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

.github/sync-repo-settings.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,5 @@ branchProtectionRules:
1616
- 'Samples - Python 3.10'
1717
- 'Samples - Python 3.11'
1818
- 'Samples - Python 3.12'
19+
- 'Samples - Python 3.13'
20+
- 'Samples - Python 3.14'

noxfile.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
UNIT_TEST_EXTRAS: List[str] = []
6262
UNIT_TEST_EXTRAS_BY_PYTHON: Dict[str, List[str]] = {}
6363

64-
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.19"]
64+
SYSTEM_TEST_PYTHON_VERSIONS: List[str] = ["3.9"]
6565
SYSTEM_TEST_STANDARD_DEPENDENCIES: List[str] = [
6666
"mock",
6767
"pytest",
@@ -82,7 +82,12 @@
8282
CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
8383

8484
nox.options.sessions = [
85-
"unit",
85+
"unit-3.9",
86+
"unit-3.10",
87+
"unit-3.11",
88+
"unit-3.12",
89+
"unit-3.13",
90+
"unit-3.14",
8691
"system",
8792
"cover",
8893
"lint",

pytest.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ filterwarnings =
2828
# Remove warning once https://github.com/googleapis/gapic-generator-python/issues/2046 is fixed
2929
ignore:coroutine 'AsyncMockMixin._execute_mock_call' was never awaited:RuntimeWarning
3030
# Remove once credential file support is removed
31-
ignore:.*The \`credentials_file\` argument is deprecated.*:DeprecationWarning
31+
ignore:.*The \`credentials_file\` argument is deprecated.*:DeprecationWarning

samples/snippets/export_test.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,9 @@ def cleanup_old_sinks():
7979
# Bucket timestamp is int(time.time() * 1000)
8080
bucket_timestamp = int(match.group(1))
8181
if TIMESTAMP - bucket_timestamp // 1000 > CLEANUP_THRESHOLD:
82+
# Delete all blobs in the bucket before deleting the bucket.
83+
for blob in bucket.list_blobs():
84+
_delete_object(blob)
8285
_delete_object(bucket)
8386

8487

0 commit comments

Comments
 (0)