Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Commit 01a0acb

Browse files
committed
adjust how exactly once passed to callback loggers
1 parent 1b0a175 commit 01a0acb

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,6 @@ def _wrap_callback_errors(
143143
callback: Callable[["google.cloud.pubsub_v1.subscriber.message.Message"], Any],
144144
on_callback_error: Callable[[BaseException], Any],
145145
message: "google.cloud.pubsub_v1.subscriber.message.Message",
146-
exactly_once_enabled: bool = False,
147146
):
148147
"""Wraps a user callback so that if an exception occurs the message is
149148
nacked.
@@ -157,7 +156,7 @@ def _wrap_callback_errors(
157156
message.message_id,
158157
message.ack_id,
159158
message.ordering_key,
160-
exactly_once_enabled,
159+
message.exactly_once_enabled,
161160
)
162161

163162
try:
@@ -177,7 +176,7 @@ def _wrap_callback_errors(
177176
message.message_id,
178177
message.ack_id,
179178
message.ordering_key,
180-
exactly_once_enabled,
179+
message.exactly_once_enabled,
181180
)
182181

183182
message.nack()
@@ -909,8 +908,7 @@ def open(
909908
self._callback = functools.partial(
910909
_wrap_callback_errors,
911910
callback,
912-
on_callback_error,
913-
exactly_once_enabled=self._exactly_once_delivery_enabled,
911+
on_callback_error
914912
)
915913

916914
# Create the RPC

google/cloud/pubsub_v1/subscriber/message.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -561,3 +561,7 @@ def nack_with_response(self) -> "futures.Future":
561561
)
562562

563563
return future
564+
565+
@property
566+
def exactly_once_enabled(self):
567+
return self._exactly_once_delivery_enabled_func()

0 commit comments

Comments
 (0)