fix: add smt suffix in tests too; fix pytest eol error in py3.9

Author: abbrowne126

samples/snippets/publisher_test.py

@@ -316,15 +316,16 @@ def test_create_topic_with_confluent_cloud_ingestion(
 def test_create_with_smt(
     publisher_client: pubsub_v1.PublisherClient, capsys: CaptureFixture[str]
 ) -> None:
+    smt_topic_name = f"{TOPIC_ID}-smt"
     # The scope of `topic_path` is limited to this function.
-    topic_path = publisher_client.topic_path(PROJECT_ID, TOPIC_ID)
+    topic_path = publisher_client.topic_path(PROJECT_ID, smt_topic_name)
 
     try:
         publisher_client.delete_topic(request={"topic": topic_path})
     except NotFound:
         pass
 
-    publisher.create_topic_with_smt(PROJECT_ID, TOPIC_ID)
+    publisher.create_topic_with_smt(PROJECT_ID, smt_topic_name)
 
     out, _ = capsys.readouterr()
     assert f"Created topic: {topic_path} with SMT" in out

samples/snippets/requirements-test.txt

@@ -1,5 +1,6 @@
 backoff==2.2.1
-pytest==9.0.2
+pytest==8.4.2; python_version <= '3.9'
+pytest==9.0.2; python_version > '3.9'
 mock==5.2.0
 flaky==3.8.1
 google-cloud-bigquery==3.40.0

samples/snippets/subscriber_test.py

@@ -585,7 +585,7 @@ def test_create_subscription_with_smt(
     capsys: CaptureFixture[str],
 ) -> None:
     subscription_for_create_name = (
-        f"subscription-test-subscription-for-create-with-smt-{PY_VERSION}-{UUID}"
+        f"subscription-test-subscription-for-create-with-smt-{PY_VERSION}-{UUID}-smt"
     )
 
     subscription_path = subscriber_client.subscription_path(