Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Commit a6a3b22

Browse files
committed
fix mock generation
1 parent dcfaeff commit a6a3b22

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,14 @@ def _wrap_callback_errors(
151151
callback: The user callback.
152152
message: The Pub/Sub message.
153153
"""
154+
_CALLBACK_DELIVERY_LOGGER.debug(
155+
"Message (id=%s, ack_id=%s, ordering_key=%s, exactly_once=%s) received by subscriber callback",
156+
message.message_id,
157+
message.ack_id,
158+
message.ordering_key,
159+
message.exactly_once_enabled,
160+
)
161+
154162
try:
155163
if message.opentelemetry_data:
156164
message.opentelemetry_data.end_subscribe_concurrency_control_span()
@@ -162,9 +170,15 @@ def _wrap_callback_errors(
162170
# Note: the likelihood of this failing is extremely low. This just adds
163171
# a message to a queue, so if this doesn't work the world is in an
164172
# unrecoverable state and this thread should just bail.
165-
_LOGGER.exception(
166-
"Top-level exception occurred in callback while processing a message"
173+
174+
_CALLBACK_EXCEPTION_LOGGER.exception(
175+
"Message (id=%s, ack_id=%s, ordering_key=%s, exactly_once=%s)'s callback threw exception, nacking message.",
176+
message.message_id,
177+
message.ack_id,
178+
message.ordering_key,
179+
message.exactly_once_enabled,
167180
)
181+
168182
message.nack()
169183
on_callback_error(exc)
170184

tests/unit/pubsub_v1/subscriber/test_streaming_pull_manager.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,9 @@
5959
from google.rpc import code_pb2
6060
from google.rpc import error_details_pb2
6161

62-
_message_mock = mock.create_autospec(message.Message, instance=True)
63-
6462

6563
def create_mock_message(**kwargs):
64+
_message_mock = mock.create_autospec(message.Message, instance=True)
6665
msg = _message_mock.return_value
6766
for k, v in kwargs.items():
6867
setattr(msg, k, v)

0 commit comments

Comments
 (0)